Changed makeModules to return a broccoli MergedTree #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was bashing my head off the desk trying to figure out why my Brocfile wasn't compiling. After some digging I realized that broccoli-dist-es6-module was returning an array of trees, not a tree. The fix was simple enough, turn the result into a merged tree. I feel like broccoli-dist-es6-module should do this itself to maintain a consistent experience for Broccoli users.
Let me know what you think. Also thanks a ton for all your work around this, it really helped me get up to speed a lot faster than I would have otherwise. I was a globals scumbag before ES6 tooling.