Limit scope of allow(coherence_leak_check)
#4339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
allow-coherence-check
branch
from
d684098 to
e119855
Compare
daxpedda
force-pushed
the
allow-coherence-check
branch
from
e119855 to
100533c
Compare
daxpedda
changed the title
coherence_leak_check?allow(coherence_leak_check)
daxpedda
changed the title
allow(coherence_leak_check) allow(coherence_leak_check)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm-bindgenhad a top-levelallow(coherence_leak_check). This PR moves it to only cover the lines needed. I briefly attempted to figure out a way to properly fix this, but it doesn't seem possible right now, see rust-lang/rust#56105 (comment).To fix this properly it might require something like negative impls.