Allow creating Vecs of exported enums
#3624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also implements `TryFrom<JsValue>` and `Into<JsValue>` for them. Enums were left behind in rustwasm#3554. This adds the missing bits.
daxpedda
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
LGTM!
As the author of the original implementation I'm gonna wait for @Liamolucko's approval.
Liamolucko
reviewed
Sep 20, 2023
|
when will this ship? wasm-bindgen hasn't had a release in months. This and #3554 would be really nice to be able to actually use! |
|
See #3530. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also implements
TryFrom<JsValue>andInto<JsValue>for them.Enums were left behind in #3554. This adds the missing bits.