Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tombstone arena #58

Merged
merged 3 commits into from
Feb 19, 2019
Merged

Tombstone arena #58

merged 3 commits into from
Feb 19, 2019

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Feb 16, 2019

No description provided.

@fitzgen
Add a TombstoneArena built on top of id_arena::Arena
b0a794f 
Doesn't bother with the ArenaBehavior for now. If we need it, we can add it.
@fitzgen
Add delete methods to a bunch of our ModuleBlah types
a2d2e8a
@fitzgen fitzgen requested a review from alexcrichton February 16, 2019 00:53
alexcrichton
alexcrichton approved these changes Feb 19, 2019
View reviewed changes
Copy link
Collaborator

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I was worried about making things slower with two lookups, but this isn't done for expressions (which I think is correct) so things like visitation shouldn't really slow down

Looks like CI is failing though?

@fitzgen fitzgen mentioned this pull request Feb 19, 2019
Merged
@alexcrichton alexcrichton merged commit 9d7122d into rustwasm:master Feb 19, 2019
@fitzgen fitzgen deleted the tombstone-arena branch February 19, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fitzgen @alexcrichton