Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Module::from_buffer_with_config #285

Conversation

kateinoigakukun
Copy link
Contributor

@kateinoigakukun kateinoigakukun commented Dec 3, 2024

Current Module construction API cannot create a module from a buffer with a specific configuration:

  • Module::with_config
  • Module::from_file
  • Module::from_file_with_config
  • Module::from_buffer

This commit adds a new method Module::from_buffer_with_config to fill the gap.

We are using this API to instrument wasm binary on browsers without relying on file system: https://github.com/kateinoigakukun/wasm-memprof

Current `Module` construction API cannot create a module from a buffer
with a specific configuration:
  * `Module::with_config`
  * `Module::from_file`
  * `Module::from_file_with_config`
  * `Module::from_buffer`

This commit adds a new method `Module::from_buffer_with_config` to fill
the gap.
@guybedford guybedford merged commit 9b4bb16 into rustwasm:main Dec 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants