Add missing ops to enable upgrade to 0.214 #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To clariy, this change is necessary if we want walrus to build with wasmparser >=0.214 An alternative approach is to give up on enumerating all instructions and accept a catch-all case in src/module/functions/local_function/mod.rs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cases for the added shared-everything-threads instructions.
These instructions are part of the shared everything threads proposal and were added to wasmparser in bytecodealliance/wasm-tools@bf282bb
This change treats all of them as unsupported, with the intent to enable upgrading wasmparser and wasm-encoders tools dependencies in lock step.