Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable relaxed SIMD by default #281

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

daxpedda
Copy link
Contributor

This enabled the relaxed SIMD proposal, which is in phase 5, by default. wasm-bindgen currently fails without this addition when compiling Wasm modules containing relaxed SIMD instructions, which are stable since Rust v1.82.

A new point release would be appreciated as well!

@dragostis
Copy link

dragostis commented Nov 12, 2024

@daxpedda, thank you for writing the PR! Unfortunately, this is also requires adding support for it in src/module/functions/ocal_function in order to work correctly.

EDIT: I pushed an incomplete version here: main...dragostis:walrus:relaxed-simd

@daxpedda
Copy link
Contributor Author

EDIT: I pushed an incomplete version here: main...dragostis:walrus:relaxed-simd

Ah, just saw it after I finished 😅, thanks nevertheless!

I went ahead and renamed RelaxedSimd to TernOp, which seems more appropriate considering no special handling is required.

@guybedford guybedford merged commit 6be5417 into rustwasm:main Nov 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants