-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: upgrade wasmparser & wasm-encoder to v0.212.0 #266
Conversation
Thanks for the PR! I'll gladly do a review and merge here further. Are you able to get the remaining tests passing for this? |
This reverts commit 8272e87.
All CI checks have passed! Could you please review and merge my PR when you get a chance? Next up, I'll be working on the "memory64" feature in a new PR soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work, thank you for getting this one over the line. Just a couple of comments on the TODOs then it would be great to land and release this.
Co-authored-by: Guy Bedford <[email protected]>
Description
It is inevitable to introduce breaking changes so that we can make this project catch up with recent Wasm standard (and proposals).
New types
RefType
is now a separate type which coversFuncref
andExternref
used to be inValType
ElementItems
which covers bothFunctions
andExpressions
Types that have significant change
InitExpr
=>ConstExpr
Element
: additem: ElementItems
Global
: addshared: bool
Memory
:memory64: bool
u64
forinitial
andmaximum
page_size_log2: Option<u32>
Table
:table64: bool
u64
forinitial
andmaximum
Wasm Feature
In
module/mod.rs
:Fix
wasm_features
fromwasmparser::WasmFeatures::default()
regardless ofconfig.only_stable_features
.Spec tests
CI
Use the latest pre-compiled
wabt
andbinaryen
.