rename: get_func_by_name to get_func #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @vados-cosmonic |
|
Looks good to me -- thanks for the pointer, updating the WASI-Virt PR now! |
vados-cosmonic
added a commit
to vados-cosmonic/WASI-Virt
that referenced
this pull request
Oct 23, 2023
After the work done upstreaming operations used in `src/walrus_ops.rs` to walrus, the code for WASI-Virt can be updated to use the new APIs and reduce custom code. This commit updates the WASI-Virt codebase to use the upstreamed functions and adds some light refactors to the more mechanical pieces of code for stubbing/denying/stripping. see: bytecodealliance#20 see: rustwasm/walrus#252 Signed-off-by: Victor Adossi <[email protected]>
guybedford
pushed a commit
to bytecodealliance/WASI-Virt
that referenced
this pull request
Oct 23, 2023
After the work done upstreaming operations used in `src/walrus_ops.rs` to walrus, the code for WASI-Virt can be updated to use the new APIs and reduce custom code. This commit updates the WASI-Virt codebase to use the upstreamed functions and adds some light refactors to the more mechanical pieces of code for stubbing/denying/stripping. see: #20 see: rustwasm/walrus#252 Signed-off-by: Victor Adossi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the new
(imports|exports).get_func_by_nameto just(imports|exports).get_func. The main reason being that I think theby_nameterm is overloaded in the functions list already to mean the actual function name instead of the import or export name, so wanted to avoid any confusion here.Then I updated the
delete_by_namefunctions to be generic namedremovefunctions also without theby_nameterm to avoid confusion about it.