Add efi_rng opt-in backend
#570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephlr
reviewed
Dec 18, 2024
| impl Error { | ||
| pub(crate) const BOOT_SERVICES_UNAVAILABLE: Error = Self::new_internal(10); | ||
| pub(crate) const NO_RNG_HANDLE: Error = Self::new_internal(11); | ||
| pub(crate) const TEMP_EFI_ERROR: Error = Self::new_internal(12); |
There was a problem hiding this comment.
Do we need TEMP_EFI_ERROR now if we have #569 ?
There was a problem hiding this comment.
As I wrote in the OP, to encapsulate the UEFI status codes we need a wider state than 32-bits. Technically, on x86-64 we need 64 bits, but we probably can use NonZeroU64 since status codes with prefixes 0x1, 0x3, and 0x7 are used for "warning" codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is based on the
stdcode. I am not sure why we need the try loop over protocol handles instead of just getting the first handle, but I decided to just followstdhere.Because the backend requires access to
BootServicesit has to rely on the unstableuefi_stdfeature. We could alternatively use theueficrate, but it would tie the backend to theueficrate environment, which is probably not desirable.TEMP_EFI_ERRORis used as a temporary solution until #568 is resolved, which I plan to do in a separate PR.cc @usamoi @nicholasbishop