-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix compilation on uefi (with std feature enabled) or i686 #566
Conversation
I don't understand why we need the Also please add a build-only CI job for this target, see here. |
@newpavlov If we use std on uefi targets, code does not compile since |
But we do not use |
Could you please split the |
Ok. I'll remove code about |
This reverts commit 2da5387.
It may be worth to reconsider our use of But it's unclear how it's better to do this. I don't think we should just double the |
Thank you! |
According to https://uefi.org/specs/UEFI/2.10/Apx_D_Status_Codes.html, there is no more space for internal errors, so use a wider integer on UEFI.