MSRV 1.59: Remove libc requirement for x86_64-*-linux-none #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansmith
force-pushed
the
b/syscall-x86_64
branch
from
a9719e4 to
c4538e2
Compare
briansmith
changed the title
briansmith
force-pushed
the
b/syscall-x86_64
branch
from
c4538e2 to
14f6df9
Compare
briansmith
force-pushed
the
b/syscall-x86_64
branch
from
14f6df9 to
6d35e22
Compare
briansmith
commented
Jun 6, 2024
briansmith
force-pushed
the
b/syscall-x86_64
branch
5 times, most recently
from
6533252 to
c60c94e
Compare
Prepare for removing the libc dependency from it.
Make progress on reoving the libc dependency from util_unix, so we can remove the libc dependency for x86_64-unknown-linux-none.
briansmith
force-pushed
the
b/syscall-x86_64
branch
from
c60c94e to
46a253e
Compare
briansmith
commented
Jun 7, 2024
src/linux_android.rs
Outdated
| } | ||
| match Word::try_from(ret) { | ||
| Ok(written) => { | ||
| const _:() = assert!(core::mem::size_of::<Word>() <= core::mem::size_of::<usize>()); |
There was a problem hiding this comment.
Depending on whether/how #463 is resolved, we may need to unpoison(dest, written) here.
| 0, | ||
| ) | ||
| }; | ||
| const _:() = assert!(core::mem::size_of::<libc::c_long>() == core::mem::size_of::<isize>()); |
|
Since the current implementation already doesn't work in MSAN (on Linux), we don't have to block this on MSAN support. |
briansmith
force-pushed
the
b/syscall-x86_64
branch
2 times, most recently
from
3ad27bf to
37386af
Compare
briansmith
commented
Jun 7, 2024
| // | ||
| // #[cfg(target_abi = "x832")] | ||
| // #[allow(non_upper_case_globals)] | ||
| // pub const SYS_getrandom: IWord = 318 | __X32_SYSCALL_BIT; |
There was a problem hiding this comment.
It isn't clear to me that we actually need to use __X32_SYSCALL_BIT for x86_64-unknown-linux-gnux32 and other x32 targets. It seems like we could just use the 64-bit version of the syscall instead (i.e. same syscall number). But I am not so sure and it's hard for me to test x32.
…-none. Remove the last libc dependency from `linux_android`, as a step towards supporting x86_64-unknown-linux-none. This requires bumping the MSRV to 1.59.
briansmith
force-pushed
the
b/syscall-x86_64
branch
from
37386af to
86c1382
Compare
briansmith
changed the title
briansmith
changed the title
|
Closing in favor of #520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.