Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong calculation of data_buffer_pointer of transfer::Normal #154

Merged

Conversation

lemolatoon
Copy link
Contributor

As defined in xHCI Specification 6.4.1.1 Normal TRB , Normal TRB's first 32bit is Data Buffer Pointer Lo, and next 32bit is Data Buffer Pointer Hi.

Before this patch, the calculation of Data Buffer Pointer in Normal TRB is wrong. So I fixed it.

Thank you.

@lemolatoon
Copy link
Contributor Author

error: lint `unaligned_references` has been removed: converted into hard error, see issue #82523 <https://github.com/rust-lang/rust/issues/82523> for more information
  --> src/lib.rs:51:5
   |
51 |     unaligned_references,
   |     ^^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D renamed-and-removed-lints` implied by `-D warnings`

This lint error does not originate from this pull request. Is it preferable to fix this lint error also in this pull request?

@toku-sa-n
Copy link
Member

error: lint `unaligned_references` has been removed: converted into hard error, see issue #82523 <https://github.com/rust-lang/rust/issues/82523> for more information
  --> src/lib.rs:51:5
   |
51 |     unaligned_references,
   |     ^^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D renamed-and-removed-lints` implied by `-D warnings`

This lint error does not originate from this pull request. Is it preferable to fix this lint error also in this pull request?

I'll fix it in another PR. Sorry, but please wait for it.

@toku-sa-n
Copy link
Member

@lemolatoon Sorry, but please wait more time because passing the Clippy action is not completed yet due to a problem with the action itself.

@lemolatoon
Copy link
Contributor Author

lemolatoon commented Jul 18, 2023

@toku-sa-n
I understand.

Thank you for maintaining this great crate! I am really helped.

@toku-sa-n
Copy link
Member

Thank you for waiting. Could you update the branch?

src/ring/trb/transfer.rs Outdated Show resolved Hide resolved
@lemolatoon lemolatoon force-pushed the fix-normal-trb-data-buffer-pointer-calc branch from 84257de to 9083305 Compare July 19, 2023 12:01
@toku-sa-n toku-sa-n merged commit 6098779 into rust-osdev:main Jul 19, 2023
@toku-sa-n
Copy link
Member

Thank you! I'll upload a new version soon.

@toku-sa-n
Copy link
Member

Published as 0.9.2.

@lemolatoon lemolatoon deleted the fix-normal-trb-data-buffer-pointer-calc branch July 19, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants