-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test hello-world example with Android Emulator on CI #133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't reviewed in detail, but looks cool and simple enough!
ee580b0
to
457cacf
Compare
457cacf
to
1bd4bdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, the test works now! We should probably come up with a more sophisticated test-case at some point, but validating app startup and "hello world"
being printed is an important first milestone. Thanks!
@Gordon-F Would you be able to help out? For quite some time now the CI seems to be unresponsive around https://github.com/rust-windowing/android-ndk-rs/actions/runs/1452352305 |
I vaguely remember writing down some more info in #169, too. |
@MarijnS95 It looks like an infrastructure problem on the GitHub runner side. Is |
Also, the emulator starts 3 times for 3 different tasks, if I understood everything correctly. Is it necessary? It seems to me that it would be more optimal to start it only 1 time and run all tests on it. |
The broken run also shows that it was on 10.15:
But we'd like to have a clean emulator for every artifact that we need to test. Could deinstall the application but that seems far from ideal. However, perhaps starting 3 of them instead of one is the problem "somehow" in scheduling? |
Android-emulator-runner docs suggest using a clean snapshot to speed up CI in this case. What do you think about it? It should speed up CI time and maybe help with the runner issue. |
Yeah, we can try that :) |
It's a bit strange because this shouldn't happen regardless (I kept the |
No description provided.