use roles for compiler team maintainers #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidtwco
commented
Nov 12, 2024
davidtwco
commented
- Allow alumni to have roles as the compiler team want to recognise the team member for the role they had while active
- Remove compiler team maintainer subteam and add these as roles to the team members
davidtwco
force-pushed
the
compiler-team-use-roles-for-maintainers
branch
from
f3c33e8 to
baea39a
Compare
|
Needs rust-lang/www.rust-lang.org#2088 to show the alumni roles on the website, but this needs merged first |
wesleywiser
approved these changes
Nov 12, 2024
rylev
previously approved these changes
Nov 18, 2024
| @@ -478,6 +474,10 @@ impl Team { | |||
| &self.people.members | |||
| } | |||
|
|
|||
| pub(crate) fn explicit_alumni(&self) -> &[TeamMember] { | |||
There was a problem hiding this comment.
I'm not sure I understand the explicit_alumni naming (as opposed to just alumni). Can you explain why that's preferable?
There was a problem hiding this comment.
It just mirrors the members naming - explicit_members returns the TeamMembers directly, and members returns an elaborated list of members as &'a str. It doesn't make sense to have a alumni equivalent of that, but I thought it made sense for explicit_alumni to return TeamMembers.
|
Pinging this as it looks mergeable and would be a nice improvement. |
|
Happy to merge with a rebase. |
This enables the compiler team to recognise their alumni for the role that they held while active.
davidtwco
force-pushed
the
compiler-team-use-roles-for-maintainers
branch
from
baea39a to
5dc34b0
Compare
|
Rebased! |
Mark-Simulacrum
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.