Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move wg-polonius to t-types #1070

Merged
merged 1 commit into from
Sep 14, 2023
Merged

move wg-polonius to t-types #1070

merged 1 commit into from
Sep 14, 2023

Conversation

lqd
Copy link
Member

@lqd lqd commented Sep 8, 2023

As described in the initial t-types announcement/plans:

Another relevant working group is the polonius working group, which primarily works on the design and implementation of the Polonius borrow-checking library. While the working group itself will remain, it is now also under the purview of the types team.

This PR moves the WG under t-types rather than t-compiler. Note that the move is limited in what the team repo and website support (much like t-types' structure itself): subteams currently can't have working groups.

It's not a big deal:

  1. we can still have the WG as a child of t-compiler in the team repository -- this is still ultimately true transitively :) -- and document that it's a t-types WG. This is what this PR does.
  2. or, have the wg be a team. @fmease has recently made changes to allow subteams to have their own subteams.

Let me know what you think @nikomatsakis and @jackh726. It feels the WG structure has merit in this case, compared to making it a t-types subteam. It seems fine to me to document that this is a t-types WG, but still attach it to t-compiler in the existing data structure of the team repo and website UI.

(This ultimately feels fixable, but I'm not sure it's absolutely necessary right now)

@lqd lqd force-pushed the polonius-subteam branch from ef9f69c to c157e9e Compare September 8, 2023 13:58
@fmease
Copy link
Member

fmease commented Sep 8, 2023

Ah, in #1046 I only allowed subteams (like types) to have subteams but not working groups (like wg-polonius) since there isn't a nice way to render the latter on the website. If you find a solution to nicely render WGs of subteams on the website (see rust-lang/www.rust-lang.org#1857), you can just lift this restriction, I'd say.

You dropping kind = "working-group" makes the subsubteam check succeed (since you've essentially turned the WG into a team) but of course it makes the prefix check fail.

@lqd
Copy link
Member Author

lqd commented Sep 8, 2023

Thanks, I was looking at the PR to remove/update that limitation. Otherwise we'll just turn the WG into a team :)

and move dylan to alumni
@lqd lqd force-pushed the polonius-subteam branch from c157e9e to b3cd651 Compare September 8, 2023 16:27
@lqd
Copy link
Member Author

lqd commented Sep 8, 2023

Or just move it in spirit but not in the website structure for real: it's documented, but we don't need the UI to be fixed to explain the team structure per se. Much like t-types itself.

@lqd lqd marked this pull request as ready for review September 8, 2023 16:46
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to eventually get proper support of this (and types as subteam of lang+compiler), but this is good for now :)

@rylev rylev merged commit c2b5a69 into rust-lang:master Sep 14, 2023
1 check passed
@lqd lqd deleted the polonius-subteam branch September 14, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants