Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove buffers in tests for {f,}xsave{c,}{64,} #1690

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Remove buffers in tests for {f,}xsave{c,}{64,} #1690

merged 1 commit into from
Dec 13, 2024

Conversation

marxin
Copy link
Contributor

@marxin marxin commented Dec 13, 2024

Fixes: #1672

@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Amanieu Amanieu added this pull request to the merge queue Dec 13, 2024
@Amanieu
Copy link
Member

Amanieu commented Dec 13, 2024

We should maybe also consider deprecating these intrinsics. I don't think there is a way to use them correctly without inline assembly.

Merged via the queue into rust-lang:master with commit f45b47c Dec 13, 2024
56 checks passed
@marxin marxin deleted the remove-xsave-area-cmp-in-tests branch December 13, 2024 15:52
@sayantn
Copy link
Contributor

sayantn commented Dec 13, 2024 •
edited
Loading

Also, IG we can now re-enable the x86_64-pc-windows-msvc-dev test

@sayantn sayantn mentioned this pull request Dec 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core_arch::x86::xsave::tests::test_xsavec{,64} fails on Windows
4 participants
@marxin @rustbot @Amanieu @sayantn