Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes and cleanups #1687

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Small fixes and cleanups #1687

merged 3 commits into from
Dec 12, 2024

Conversation

sayantn
Copy link
Contributor

@sayantn sayantn commented Dec 6, 2024 •
edited
Loading

  • Remove redundant target features - these were due to the inline asm requirement, which was removed with implied target features
  • Use core::intrinsics::fmaf16 in avx512fp16 intrinsics
  • Add instruction assertions for AMX - windows-gnu, apple-darwin and ios-macabi targets are problematic as usual

@sayantn
Cleanup: remove redundant target features
94f2f9c 
Make target feature verification stricter
@rustbot
Copy link
Collaborator

rustbot commented Dec 6, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@sayantn sayantn force-pushed the small-fixes branch 2 times, most recently from 6cea30b to a84a980 Compare December 6, 2024 20:48
@sayantn sayantn force-pushed the small-fixes branch 3 times, most recently from 9477abc to a695f2b Compare December 6, 2024 21:35
@sayantn sayantn marked this pull request as ready for review December 6, 2024 21:35
@Amanieu Amanieu added this pull request to the merge queue Dec 12, 2024
Merged via the queue into rust-lang:master with commit be5917b Dec 12, 2024
111 checks passed
@sayantn sayantn deleted the small-fixes branch December 14, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sayantn @rustbot @Amanieu