Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize x86 F16C #1366

Merged
merged 2 commits into from
Mar 12, 2023
Merged

Stabilize x86 F16C #1366

merged 2 commits into from
Mar 12, 2023

Conversation

starkat99
Copy link
Contributor

@starkat99 starkat99 commented Dec 31, 2022

Resolves #1234

Compiler PR for stabilizing corresponding target_feature: rust-lang/rust#106323

@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

@Amanieu
Copy link
Member

Amanieu commented Jan 5, 2023

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Jan 5, 2023

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 12, 2023
…ature, r=petrochenkov

Stabilize f16c_target_feature

Resolves rust-lang/stdarch#1234

Library PR for stabilizing corresponding intrinsics: rust-lang/stdarch#1366

See also rust-lang#44839 tracking issue for target_feature
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 12, 2023
…ature, r=petrochenkov

Stabilize f16c_target_feature

Resolves rust-lang/stdarch#1234

Library PR for stabilizing corresponding intrinsics: rust-lang/stdarch#1366

See also rust-lang#44839 tracking issue for target_feature
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Jan 13, 2023
…petrochenkov

Stabilize f16c_target_feature

Resolves rust-lang/stdarch#1234

Library PR for stabilizing corresponding intrinsics: rust-lang/stdarch#1366

See also #44839 tracking issue for target_feature
@starkat99
Copy link
Contributor Author

rust-lang/rust#106323 was merged, which stabilized the target feature

@rfcbot
Copy link

rfcbot commented Feb 28, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

psst @Amanieu, I wasn't able to add the final-comment-period label, please do so.

@rfcbot
Copy link

rfcbot commented Mar 10, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

psst @Amanieu, I wasn't able to add the finished-final-comment-period label, please do so.

@Amanieu Amanieu merged commit 5b82011 into rust-lang:master Mar 12, 2023
@Shnatsel
Copy link
Member

Github shows that this was merged after the release of Rust 1.68, but the attributes still indicate #[stable(since = "1.68.0")]. Is that intentional? If not, perhaps the attributes should be updated?

thomcc pushed a commit to tcdi/postgrestd that referenced this pull request May 31, 2023
…petrochenkov

Stabilize f16c_target_feature

Resolves rust-lang/stdarch#1234

Library PR for stabilizing corresponding intrinsics: rust-lang/stdarch#1366

See also #44839 tracking issue for target_feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is F16C still unstable?
5 participants