Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cfg_if! parsing during module resolution #5341

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improve cfg_if! parsing during module resolution #5341

wants to merge 4 commits into from

Conversation

ytmimi
Copy link
Contributor

@ytmimi ytmimi commented May 13, 2022 •
edited
Loading

Fixes #4442

  • Prevent Infinite loop when reaching tokens that can't be parsed as items. For example, nested if #[..] checks.
  • Handle arbitrarily nested if #[..], else if #[..], else checks.
Edit: closes #5428

@ytmimi ytmimi mentioned this pull request Jul 6, 2022
Closed
@ytmimi ytmimi added the p-low label Jul 28, 2022
@VictorKoenders VictorKoenders mentioned this pull request Nov 3, 2022
Merged
ytmimi added 4 commits June 24, 2024 15:13
@ytmimi
Improve cfg_if! parsing during module resolution
c3ab010 
Fixes 4442

* Prevent Infinite loop when reaching tokens that can't be parsed as
  items. For example, nested `if #[..]` checks.
* Handle arbitrarily nested `if #[..]`, `else if #[..]`, `else` checks.
@ytmimi
Add cfg_if! test case for issue 5428
df9a3a0
@ytmimi
Add cfg_if! test case for issue 5413
3c1160d
@ytmimi
Add test case for issue 6215
853e9d1
@ytmimi ytmimi mentioned this pull request Jun 24, 2024
Closed
@ytmimi ytmimi mentioned this pull request Jul 25, 2024
Closed
@ytmimi ytmimi mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
p-low pr-not-reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rusfmt hangs when using cfg-if macro Aborted using cfg-if: memory allocation of <tons of> bytes failed
1 participant
@ytmimi