Grep check for LTO Test #600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoyo
reviewed
Jan 15, 2025
.github/workflows/release.yml
Outdated
| # TODO: grep the asm output for "call my_func" and fail if it is found. | ||
| asm=$(objdump -dj .text tests/hello-world/target/release/hello_world) | ||
| if echo asm | grep -q "call .*mylib.*my_func" ; then | ||
| echo "call my_func found in asm" |
There was a problem hiding this comment.
Please add in this string something saying that it should not be found because LTO should have removed it and that this tests LTO.
.github/workflows/release.yml
Outdated
Comment on lines
79
to
80
| asm=$(objdump -dj .text tests/hello-world/target/release/hello_world) | ||
| if echo asm | grep -q "call .*mylib.*my_func" ; then |
There was a problem hiding this comment.
It's probably more efficient to do:
Suggested change
| asm=$(objdump -dj .text tests/hello-world/target/release/hello_world) | |
| if echo asm | grep -q "call .*mylib.*my_func" ; then | |
| call_found=$(objdump -dj .text tests/hello-world/target/release/hello_world | grep -q "call .*mylib.*my_func") | |
| if call_found then |
.github/workflows/release.yml
Outdated
Comment on lines
83
to
84
| else | ||
| echo "success" |
There was a problem hiding this comment.
No need to print this.
Suggested change
| else | |
| echo "success" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #591