-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tendril #98411
Update tendril #98411
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
@Mark-Simulacrum I'm curious if you have any opinions about somehow denying these warnings? It is not currently possible AFAIK, but it might be helpful to uncover these hidden warnings. |
Do you have a reference/link for how to reproduce the warning? Maybe we could use the force lint level to bypass cap-lints... I'm a little worried that we might experience these lints during beta bumps in practice (when they're newly introduced via bootstrap tools), which seems like a bad time for them to appear... normally new lints are in-tree so we can easily enough fix them, but in dependencies that's not the case. One solution could be toolstate-like denies, maybe. |
r=me on the PR itself though |
I think in order to deny these warnings, there will either need to be something added to rustc or cargo. I'm guessing cargo. I think my idea was to have the ability to control lint levels from cargo, and have this be just another control (like "deny" I'm not sure what is meant by "toolstate-like denies". If that is something like "future-incompat warnings exist" is an entry in the toolstate database, that would help with exposing the warnings more visibly. I'm not sure how that could work. Unfortunately Cargo doesn't emit any sort of JSON messages to help here. The hope was that these kinds of warnings would be extremely rare, but perhaps that was wishful thinking on my part. @bors r=Mark-Simulacrum |
📌 Commit 04b75a7 has been approved by |
🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened. |
Rollup of 9 pull requests Successful merges: - rust-lang#91264 (Add macro support in jump to definition feature) - rust-lang#96955 (Remove (transitive) reliance on sorting by DefId in pretty-printer) - rust-lang#97633 (Session object: Set OS/ABI) - rust-lang#98039 (Fix `panic` message for `BTreeSet`'s `range` API and document `panic` cases) - rust-lang#98214 (rustc_target: Remove some redundant target properties) - rust-lang#98280 (Improve suggestion for calling fn-like expr on type mismatch) - rust-lang#98394 (Fixup missing renames from `#[main]` to `#[rustc_main]`) - rust-lang#98411 (Update tendril) - rust-lang#98419 (Remove excess rib while resolving closures) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
The 0.4.1 version of
tendril
(used by mdbook) triggers theunaligned_references
lint which is now reported as a future-compatibility warning as of #95372. This updates it to 0.4.3 which does not trigger the warning. This update also triggered the update offutf
from 0.1.4 to 0.1.5.tendril changes: servo/tendril@v0.4.1...v0.4.3
futf changes: servo/futf@v0.1.4...v0.1.5