-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move download-rustc from python to rustbuild #96687
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
03f0a9a
to
3dc6364
Compare
r=me with nits fixed |
@Mark-Simulacrum this is ready for review :) |
☔ The latest upstream changes (presumably #96602) made this pull request unmergeable. Please resolve the merge conflicts. |
@rustbot ready |
This has no logic changes, just a move.
- Remove download-rustc handling from bootstrap.py - Allow a custom `pattern` in `builder.unpack()` - Only download rustc once another part of bootstrap depends on it. This is somewhat necessary since the download functions rely on having a full `Builder`, which isn't available until after config parsing finishes.
This is for a pre-existing FIXME, but it was easy enough to do.
@bors r+ rollup=iffy |
📌 Commit 00bb4df has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (303d916): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
…ulacrum Move rustfmt downloads from bootstrap.py to rustbuild - Allow verifying CI downloads using src/stage0.json - Change download functions not to hard-code `ci-artifacts.rust-lang.org` - Change `format::format` to take a `Builder` so it has access to `download_component`. I think we may want to reconsider the distinction between Build and Builder at some point; I don't think it's particularly useful. - Move rustfmt downloads out of bootstrap.py Fixes rust-lang#95136. Helps with rust-lang#94829. This is based on rust-lang#96687 for simplicity.
Remove download-rustc handling from bootstrap.py
Allow a custom
pattern
inbuilder.unpack()
Only download rustc once another part of bootstrap depends on it.
This is somewhat necessary since the download functions rely on having a full
Builder
, which isn't available until after config parsing finishes.Helps with #94829.