Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused macro rules #96149

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Remove unused macro rules #96149

merged 1 commit into from
Apr 26, 2022

Conversation

est31
Copy link
Member

@est31 est31 commented Apr 17, 2022

Removes rules of internal macros that weren't triggered.

@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 17, 2022
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2022
@est31 est31 mentioned this pull request Apr 17, 2022
Merged
@est31 est31 force-pushed the remove_unused_macro_matchers branch 3 times, most recently from bebd139 to 9a915bc Compare April 17, 2022 20:56
@est31 est31 force-pushed the remove_unused_macro_matchers branch from 9a915bc to 3c1e166 Compare April 18, 2022 21:28
@est31
Copy link
Member Author

est31 commented Apr 24, 2022

This is a prerequisite for #96150. r? @petrochenkov

@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 25, 2022

📌 Commit 3c1e166 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2022
@compiler-errors compiler-errors mentioned this pull request Apr 25, 2022
Closed
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Apr 25, 2022
@compiler-errors
Rollup merge of rust-lang#96149 - est31:remove_unused_macro_matchers,…
fcc18ff 
… r=petrochenkov

Remove unused macro rules

Removes rules of internal macros that weren't triggered.
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 25, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2022
@bors
Auto merge of rust-lang#96414 - Dylan-DPC:rollup-t4ofhoa, r=Dylan-DPC
9ea4d41 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#90312 (Fix some confusing wording and improve slice-search-related docs)
 - rust-lang#96149 (Remove unused macro rules)
 - rust-lang#96279 (rustdoc: Remove .woff font files)
 - rust-lang#96355 (Better handle too many `#` recovery in raw str)
 - rust-lang#96379 (delay bug when adjusting `NeverToAny` twice during diagnostic code)
 - rust-lang#96384 (do not consider two extern types to be similar)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 93db30a into rust-lang:master Apr 26, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 26, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 26, 2022
@Dylan-DPC
Rollup merge of rust-lang#96150 - est31:unused_macro_rules, r=fee1-dead
0aec217 
Implement a lint to warn about unused macro rules

This implements a new lint to warn about unused macro rules (arms/matchers), similar to the `unused_macros` lint added by rust-lang#41907 that warns about entire macros.

```rust
macro_rules! unused_empty {
    (hello) => { println!("Hello, world!") };
    () => { println!("empty") }; //~ ERROR: 1st rule of macro `unused_empty` is never used
}

fn main() {
    unused_empty!(hello);
}
```

Builds upon ~~(and currently integrates)~~ rust-lang#96149 and rust-lang#96156.

Fixes rust-lang#73576
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 6, 2022
@GuillaumeGomez
Rollup merge of rust-lang#96150 - est31:unused_macro_rules, r=petroch…
914f947 
…enkov

Implement a lint to warn about unused macro rules

This implements a new lint to warn about unused macro rules (arms/matchers), similar to the `unused_macros` lint added by rust-lang#41907 that warns about entire macros.

```rust
macro_rules! unused_empty {
    (hello) => { println!("Hello, world!") };
    () => { println!("empty") }; //~ ERROR: 1st rule of macro `unused_empty` is never used
}

fn main() {
    unused_empty!(hello);
}
```

Builds upon rust-lang#96149 and rust-lang#96156.

Fixes rust-lang#73576
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 6, 2022
@GuillaumeGomez
Rollup merge of rust-lang#96150 - est31:unused_macro_rules, r=petroch…
9ac8200 
…enkov

Implement a lint to warn about unused macro rules

This implements a new lint to warn about unused macro rules (arms/matchers), similar to the `unused_macros` lint added by rust-lang#41907 that warns about entire macros.

```rust
macro_rules! unused_empty {
    (hello) => { println!("Hello, world!") };
    () => { println!("empty") }; //~ ERROR: 1st rule of macro `unused_empty` is never used
}

fn main() {
    unused_empty!(hello);
}
```

Builds upon rust-lang#96149 and rust-lang#96156.

Fixes rust-lang#73576
bors added a commit to rust-lang-ci/rust that referenced this pull request May 12, 2022
@bors
Auto merge of rust-lang#96150 - est31:unused_macro_rules, r=petrochenkov
0cd939e 
Implement a lint to warn about unused macro rules

This implements a new lint to warn about unused macro rules (arms/matchers), similar to the `unused_macros` lint added by rust-lang#41907 that warns about entire macros.

```rust
macro_rules! unused_empty {
    (hello) => { println!("Hello, world!") };
    () => { println!("empty") }; //~ ERROR: 1st rule of macro `unused_empty` is never used
}

fn main() {
    unused_empty!(hello);
}
```

Builds upon rust-lang#96149 and rust-lang#96156.

Fixes rust-lang#73576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
6 participants
@est31 @rust-highfive @petrochenkov @bors @Mark-Simulacrum @rustbot