-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MaybeUninit array cleanup #96099
MaybeUninit array cleanup #96099
Conversation
* Links MaybeUninit::uninit_array to meta-tracking issue * Links MaybeUninit::array_assume_init to meta-tracking issue * Unstably constifies MaybeUninit::array_assume_init
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
r? @thomcc (rust-highfive has picked a reviewer for you, use r? to override) |
This unstably r? rust-lang/libs-api @rustbot label +T-libs-api -T-lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@bors r+ |
📌 Commit 63a8652 has been approved by |
Rollup of 9 pull requests Successful merges: - rust-lang#93969 (Only add codegen backend to dep info if -Zbinary-dep-depinfo is used) - rust-lang#94605 (Add missing links in platform support docs) - rust-lang#95372 (make unaligned_references lint deny-by-default) - rust-lang#95859 (Improve diagnostics for unterminated nested block comment) - rust-lang#95961 (implement SIMD gather/scatter via vector getelementptr) - rust-lang#96004 (Consider lifetimes when comparing types for equality in MIR validator) - rust-lang#96050 (Remove some now-dead code that was only relevant before deaggregation.) - rust-lang#96070 ([test] Add test cases for untested functions for BTreeMap) - rust-lang#96099 (MaybeUninit array cleanup) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
The `const`-ness of `MaybeUninit::uninit_array` has been split into a separate feature by [rust-lang/rust#96099][1]. [1]: rust-lang/rust#96099
The `const`-ness of `MaybeUninit::uninit_array` has been split into a separate feature by [rust-lang/rust#96099][1]. [1]: rust-lang/rust#96099
This feature, which covers the `const fn` version of `MaybeUninit:: array_assume_init`, was added by [rust-lang/rust#96099][1]. [1]: rust-lang/rust#96099
This feature, which covers the `const fn` version of `MaybeUninit:: array_assume_init`, was added by [rust-lang/rust#96099][1]. [1]: rust-lang/rust#96099
This feature, which covers the `const fn` version of `MaybeUninit:: array_assume_init`, was added by [rust-lang/rust#96099][1]. [1]: rust-lang/rust#96099
MaybeUninit::uninit_array
to meta-tracking issueMaybeUninit::array_assume_init
to meta-tracking issueMaybeUninit::array_assume_init
Another thing worth mentioning: this splits the const feature flag for
maybe_uninit_uninit_array
intoconst_maybe_uninit_uninit_array
to avoid weird cases where only one gets stabilised.Note that it may be desired to keep the
array_assume_init
method linked to its dedicated issue, but at least for now, I decided to link to the meta-tracking issue so that all of the methods lead users to the same place. But I can revert that bit if desired.The meta-tracking issue that I filed is #96097.