Revert "Parse Ty? as Option<Ty> and provide structured suggestion"
#94574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cfc0bd1.
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
Mark-Simulacrum
added
the
beta-nominated
|
beta-nom as this fixes a regression which has slipped into beta. |
|
Can we hold off on merging until tomorrow? I'm seeing if I can patch the logic to be correct in the first place. |
|
#94593 fixes the issue with macros without reverting. |
|
r=me if necessary but I've approved #94593 |
|
☔ The latest upstream changes (presumably #94612) made this pull request unmergeable. Please resolve the merge conflicts. |
|
closing this as this is not needed |
apiraino
removed
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #92746
References #94510
r? @davidtwco
cc @estebank