Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add !align metadata on loads of &/&mut/Box #94159

Merged
merged 3 commits into from
Mar 4, 2022
Merged

Add !align metadata on loads of &/&mut/Box #94159

merged 3 commits into from
Mar 4, 2022

Conversation

erikdesjardins
Copy link
Contributor

@erikdesjardins erikdesjardins commented Feb 19, 2022 •
edited
Loading

Note that this refers to the alignment of what the loaded value points
to, not the alignment of the loaded value itself.

r? @ghost (blocked on #94158)

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Feb 19, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Feb 28, 2022

☔ The latest upstream changes (presumably #94157) made this pull request unmergeable. Please resolve the merge conflicts.

@erikdesjardins
Copy link
Contributor Author

@rustbot ready
@rustbot label: -S-blocked

r? @nikic

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 1, 2022
@erikdesjardins
Add !align metadata on loads of &/&mut/Box
69ae423 
Note that this refers to the alignment of what the loaded value points
to, _not_ the alignment of the loaded value itself.
@workingjubilee
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 1, 2022
@bors
Copy link
Contributor

bors commented Mar 1, 2022

⌛ Trying commit 69ae423 with merge b43d834a01b19434c49195195c5d72834a39d03e...

@bors
Copy link
Contributor

bors commented Mar 1, 2022

☀️ Try build successful - checks-actions
Build commit: b43d834a01b19434c49195195c5d72834a39d03e (b43d834a01b19434c49195195c5d72834a39d03e)

@rust-timer
Copy link
Collaborator

Queued b43d834a01b19434c49195195c5d72834a39d03e with parent 4ce3749, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b43d834a01b19434c49195195c5d72834a39d03e): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 1, 2022
@nikic
Copy link
Contributor

nikic commented Mar 2, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Mar 2, 2022

📌 Commit 69ae423 has been approved by nikic

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2022
@bors
Copy link
Contributor

bors commented Mar 2, 2022

⌛ Testing commit 69ae423 with merge 6e2872a1062a943af7af8f6229a4ae1c7f1225de...

@bors
Copy link
Contributor

bors commented Mar 2, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 2, 2022
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 2, 2022
@bors
Copy link
Contributor

bors commented Mar 2, 2022

⌛ Testing commit f147303 with merge cf74a40b5b9c55d4b52db5055713ebeb2cf8e64f...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Mar 2, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 2, 2022
@nikic
Copy link
Contributor

nikic commented Mar 3, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Mar 3, 2022

📌 Commit a381aef has been approved by nikic

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2022
@bors
Copy link
Contributor

bors commented Mar 3, 2022

⌛ Testing commit a381aef with merge ef8cfc7bfdd0f405888e6a4b98130008db97a8e5...

@rust-log-analyzer
Copy link
Collaborator

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
---- [ui] ui/modules/mod_dir_implicit.rs stdout ----

error: test run failed!
status: exit status: 101
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/remote-test-client" "run" "0" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/modules/mod_dir_implicit/a"
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/modules/mod_dir_implicit/a", waiting for result
------------------------------------------
--- stderr -------------------------------
--- stderr -------------------------------
thread 'main' panicked at 'client.read_exact(&mut header) failed with Connection reset by peer (os error 104)', src/tools/remote-test-client/src/main.rs:310:9
------------------------------------------

@bors
Copy link
Contributor

bors commented Mar 3, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 3, 2022
@erikdesjardins
Copy link
Contributor Author

Looks like a spurious failure due to network issues

@nikic
Copy link
Contributor

nikic commented Mar 3, 2022

@bors retry network

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2022
@bors
Copy link
Contributor

bors commented Mar 4, 2022

⌛ Testing commit a381aef with merge 62ff2bc...

@bors
Copy link
Contributor

bors commented Mar 4, 2022

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 62ff2bc to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 4, 2022
@bors bors merged commit 62ff2bc into rust-lang:master Mar 4, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 4, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (62ff2bc): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@erikdesjardins erikdesjardins deleted the align-load branch March 4, 2022 20:05
@madsmtm madsmtm mentioned this pull request Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

Assignees

@nikic nikic

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
7 participants
@erikdesjardins @rust-log-analyzer @bors @workingjubilee @rust-timer @nikic @rustbot