Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure stability directives are checked in all cases #94096

Merged
merged 9 commits into from
Mar 4, 2022
Merged

Ensure stability directives are checked in all cases #94096

merged 9 commits into from
Mar 4, 2022

Conversation

cjgillot
Copy link
Contributor

Split off #93017

Stability and deprecation were not checked in all cases, for instance if a type error happened.
This PR moves the check earlier in the pipeline to ensure the errors are emitted in all cases.

r? @lcnr

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 17, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2022
@lcnr
Copy link
Contributor

lcnr commented Feb 18, 2022

are these just the first 7 commits from #93017? and if so, did you change anything meaningful about them after my first review? If not, r=me

@cjgillot
Copy link
Contributor Author

I did not change anything except re-blessing tests after rebase.
@bors r=lcnr

@bors
Copy link
Contributor

bors commented Feb 18, 2022

📌 Commit 5ff235b has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2022
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Feb 18, 2022

🙅 Please do not try after a pull request has been r+ed. If you need to try, unapprove (r-) it first.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 18, 2022
@cjgillot
Copy link
Contributor Author

Just in case.
@bors r-
@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 18, 2022
@bors
Copy link
Contributor

bors commented Feb 18, 2022

⌛ Trying commit 5ff235b with merge 1d32a80a10c46744f5200d5dab9e702510d85418...

@bors
Copy link
Contributor

bors commented Feb 19, 2022

☀️ Try build successful - checks-actions
Build commit: 1d32a80a10c46744f5200d5dab9e702510d85418 (1d32a80a10c46744f5200d5dab9e702510d85418)

@rust-timer
Copy link
Collaborator

Queued 1d32a80a10c46744f5200d5dab9e702510d85418 with parent b17226f, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1d32a80a10c46744f5200d5dab9e702510d85418): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 19, 2022
@cjgillot
Copy link
Contributor Author

@bors r=lcnr

@bors
Copy link
Contributor

bors commented Feb 19, 2022

📌 Commit 5ff235b has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 19, 2022
@cjgillot
Copy link
Contributor Author

@bors rollup-

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 20, 2022
@matthiaskrgr
Rollup merge of rust-lang#94096 - cjgillot:ensure-stability, r=lcnr
6b80e72 
Ensure stability directives are checked in all cases

Split off  rust-lang#93017

Stability and deprecation were not checked in all cases, for instance if a type error happened.
This PR moves the check earlier in the pipeline to ensure the errors are emitted in all cases.

r? `@lcnr`
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 2, 2022
Closed
@matthiaskrgr
Copy link
Member

Looks like tests needs to be reblessed
#94532 (comment)
I'm gonna rollup=never since this seems kinda fragile
@bors r- rollup=never

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 2, 2022
@cjgillot
Copy link
Contributor Author

cjgillot commented Mar 3, 2022

@bors r=lcnr

@bors
Copy link
Contributor

bors commented Mar 3, 2022

📌 Commit c680d39 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 3, 2022
@bors
Copy link
Contributor

bors commented Mar 4, 2022

⌛ Testing commit c680d39 with merge 65f6d33...

@bors
Copy link
Contributor

bors commented Mar 4, 2022

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 65f6d33 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 4, 2022
@bors bors merged commit 65f6d33 into rust-lang:master Mar 4, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 4, 2022
This was referenced Mar 4, 2022
Closed
Merged
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (65f6d33): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@cjgillot cjgillot deleted the ensure-stability branch March 4, 2022 20:26
@madsmtm madsmtm mentioned this pull request Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
8 participants
@cjgillot @lcnr @bors @rust-timer @Manishearth @matthiaskrgr @rust-highfive @rustbot