Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide extra note if synthetic type args are specified #93982

Merged
merged 1 commit into from
Feb 26, 2022

Conversation

nbdd0121
Copy link
Contributor

Implement the unresolved question in #83701 as suggested in #86176 (comment).

r? @jackh726

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 14, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 14, 2022
@jackh726 jackh726 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2022
@nbdd0121 nbdd0121 force-pushed the explicit-generic-args branch from eafcc82 to 8040b51 Compare February 26, 2022 02:49
@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 26, 2022

📌 Commit 8040b51edb995785101f30952b47eb2af74d8609 has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 26, 2022
@rust-log-analyzer

This comment has been minimized.

@nbdd0121 nbdd0121 force-pushed the explicit-generic-args branch from 8040b51 to 6747458 Compare February 26, 2022 03:21
@nbdd0121
Copy link
Contributor Author

Conflict with #93368, rebased on latest HEAD.

@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 26, 2022

📌 Commit 6747458 has been approved by jackh726

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 26, 2022
…ackh726

Provide extra note if synthetic type args are specified

Implement the unresolved question in rust-lang#83701 as suggested in rust-lang#86176 (comment).

r? `@jackh726`
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2022
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#93400 (Do not suggest using a const parameter when there are bounds on an unused type parameter)
 - rust-lang#93982 (Provide extra note if synthetic type args are specified)
 - rust-lang#94087 (Remove unused `unsound_ignore_borrow_on_drop`)
 - rust-lang#94235 (chalk: Fix wrong debrujin index in opaque type handling.)
 - rust-lang#94306 (Avoid exhausting stack space in dominator compression)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5dcee68 into rust-lang:master Feb 26, 2022
@rustbot rustbot added this to the 1.61.0 milestone Feb 26, 2022
@nbdd0121 nbdd0121 deleted the explicit-generic-args branch April 29, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants