-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable test with self-referential generator on Miri #92121
Conversation
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
@bors r+ rollup |
📌 Commit 5994990 has been approved by |
⌛ Testing commit 5994990 with merge e3432cf718befb3d375efff27a1dcf9cfa4a8e06... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
This can't really be caused by this PR... |
⌛ Testing commit 5994990 with merge 74eac17ec1916791f19111bb5df2a6e7b399ede6... |
💔 Test failed - checks-actions |
And a crates.io network error. Wow, bors is extremely fragile the last ~week. @bors retry |
⌛ Testing commit 5994990 with merge 10db37f938e5e85f2cf8058636729e7dfbfc8c23... |
💔 Test failed - checks-actions |
Well this seems pointless, it just keeps failing (and all other PRs also failed already, the queue is empty currently) |
crates.io should be back up (https://twitter.com/cratesiostatus/status/1473671529569292296). Let's try again... @bors retry |
@bors treeclosed- |
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#90625 (Add `UnwindSafe` to `Once`) - rust-lang#92121 (disable test with self-referential generator on Miri) - rust-lang#92166 (Fixed a small typo in ui test comments) - rust-lang#92203 (Store a `DefId` instead of an `AdtDef` in `AggregateKind::Adt`) - rust-lang#92231 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Running the libcore test suite in Miri currently fails due to the known incompatibility of self-referential generators with Miri's aliasing checks (rust-lang/unsafe-code-guidelines#148). So let's disable that test in Miri for now.