Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping verbose diagnostic suggestions when calling .as_ref() on type not implementing AsRef #90399

Merged
merged 2 commits into from
Oct 30, 2021
Merged

Skipping verbose diagnostic suggestions when calling .as_ref() on type not implementing AsRef #90399

merged 2 commits into from
Oct 30, 2021

Conversation

yuvaldolev
Copy link
Contributor

Addresses #89806

Skipping suggestions when calling .as_ref() for types that do not implement the AsRef trait.

r? @estebank

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 29, 2021
@yuvaldolev yuvaldolev changed the title Skipping verbose diagnostic suggestions when calling .as_ref() on type not implementing AsRef Skipping verbose diagnostics suggestions when calling .as_ref() on type not implementing AsRef Oct 29, 2021
@yuvaldolev yuvaldolev changed the title Skipping verbose diagnostics suggestions when calling .as_ref() on type not implementing AsRef Skipping verbose diagnostic suggestions when calling .as_ref() on type not implementing AsRef Oct 29, 2021
estebank
estebank approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@estebank estebank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the changes. Can you check the one nitpick? If I'm wrong, ping me and I'll merge as is.

compiler/rustc_typeck/src/check/method/suggest.rs Show resolved Hide resolved
@yuvaldolev yuvaldolev requested a review from estebank October 29, 2021 20:51
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 29, 2021

📌 Commit cad2d21 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2021
@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 30, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 30, 2021
@bors
Auto merge of rust-lang#90422 - GuillaumeGomez:rollup-s1mdag0, r=Guil…
e249ce6 
…laumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#90156 (Remove underlines from non-top docblocks.)
 - rust-lang#90183 (Show all Deref implementations recursively)
 - rust-lang#90202 (Improve and test cross-crate hygiene)
 - rust-lang#90375 (Use `is_global` in `candidate_should_be_dropped_in_favor_of`)
 - rust-lang#90399 (Skipping verbose diagnostic suggestions when calling .as_ref() on type not implementing AsRef)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 197da45 into rust-lang:master Oct 30, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebank estebank Awaiting requested review from estebank

Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yuvaldolev @estebank @bors @rust-highfive @rustbot