Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature gate + make must_not_suspend allow-by-default #89826

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Feature gate + make must_not_suspend allow-by-default #89826

merged 1 commit into from
Nov 1, 2021

Conversation

guswynn
Copy link
Contributor

@guswynn guswynn commented Oct 12, 2021 •
edited by Mark-Simulacrum
Loading

Fixes #89798 and patches over #89562 (not a true fix, since we're just disabling the lint for now).

@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
camelid
camelid previously requested changes Oct 12, 2021
View reviewed changes
compiler/rustc_lint_defs/src/builtin.rs Outdated Show resolved Hide resolved
src/test/ui/lint/must_not_suspend/gated.rs Show resolved Hide resolved
@camelid camelid added A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2021
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 14, 2021
@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 15, 2021
@michaelwoerister
Copy link
Member

r? @nikomatsakis (owner of tracking issue #83310)

@guswynn
Copy link
Contributor Author

guswynn commented Oct 29, 2021

@ehuss @Mark-Simulacrum I believe we talked about cleaning this up, is there anything else left to do?

@Mark-Simulacrum
Copy link
Member

I'll review this soon.

@camelid camelid added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 29, 2021
@camelid
Copy link
Member

camelid commented Oct 29, 2021 •
edited
Loading

Beta-nominating since 1.57.0 is now beta. (This PR will have to be backported to beta or it'd be a breaking change.)

@camelid camelid mentioned this pull request Oct 29, 2021
Closed
@Mark-Simulacrum Mark-Simulacrum changed the title Feature gate lint directives for must_not_suspend Feature gate + make must_not_suspend allow-by-default Nov 1, 2021
@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 1, 2021
@guswynn @Mark-Simulacrum
Feature gate and make must_not_suspend allow-by-default
185fa56 
This lint is not yet ready for stable use, primarily due to false positives in edge
cases; we want to test it out more before stabilizing.
@Mark-Simulacrum Mark-Simulacrum force-pushed the feature_gate_must_not_suspend branch from 3e2fb57 to 185fa56 Compare November 1, 2021 01:22
@Mark-Simulacrum
Copy link
Member

Okay, I've gone ahead and pulled in #89787 into this PR just to make backport etc easier (force pushed a squashed commit).

Also unilaterally beta-accepted, since this is a small patch and we have to do it to avoid "breakage" (new lint warnings) on stable.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 1, 2021

📌 Commit 185fa56 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 1, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 1, 2021
@bors
Auto merge of rust-lang#90463 - matthiaskrgr:rollup-eljk9vo, r=matthi…
e9b0d99 
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#89826 (Feature gate + make must_not_suspend allow-by-default)
 - rust-lang#89929 (Handling submodule update failures more gracefully from x.py)
 - rust-lang#90333 (rustdoc: remove flicker during page load)
 - rust-lang#90349 (Fix rare ICE during typeck in rustdoc scrape_examples)
 - rust-lang#90398 (Document `doc(keyword)` unstable attribute)
 - rust-lang#90441 (Test that promotion follows references when looking for drop)
 - rust-lang#90450 (Remove `rustc_hir::hir_id::HirIdVec`)
 - rust-lang#90452 (Remove unnecessary `Option` from `promote_candidate` return type)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c654005 into rust-lang:master Nov 1, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 1, 2021
@camelid camelid mentioned this pull request Nov 1, 2021
Closed
@guswynn
Copy link
Contributor Author

guswynn commented Nov 2, 2021

Thanks for the help @Mark-Simulacrum !!

@djkoloski djkoloski mentioned this pull request Nov 4, 2021
Closed
3 tasks
@cuviper cuviper mentioned this pull request Nov 16, 2021
Merged
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 16, 2021
@cuviper cuviper modified the milestones: 1.58.0, 1.57.0 Nov 16, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 19, 2021
@bors
Auto merge of rust-lang#90938 - cuviper:beta-next, r=Mark-Simulacrum
7611e64 
[beta] backports

-  Fix assertion failures in OwnedHandle with windows_subsystem. rust-lang#88798
-  Ensure that pushing empty path works as before on verbatim paths rust-lang#89665
-  Feature gate + make must_not_suspend allow-by-default rust-lang#89826
-  Only use clone3 when needed for pidfd rust-lang#89930
-  Fix documentation header sizes rust-lang#90186
-  Fixes incorrect handling of ADT's drop requirements rust-lang#90218
-  Fix ICE when forgetting to Box a parameter to a Self::func call rust-lang#90221
-  Prevent duplicate caller bounds candidates by exposing default substs in Unevaluated rust-lang#90266
-  Update odht crate to 0.3.1 (big-endian bugfix) rust-lang#90403
-  rustdoc: Go back to loading all external crates unconditionally rust-lang#90489
-  Split doc_cfg and doc_auto_cfg features rust-lang#90502
-  Apply adjustments for field expression even if inaccessible rust-lang#90508
-  Warn for variables that are no longer captured rust-lang#90597
-  Properly register text_direction_codepoint_in_comment lint. rust-lang#90626
-  CI: Use ubuntu image to download openssl, curl sources, cacert.pem for x86 dist builds rust-lang#90457
-  Android is not GNU rust-lang#90834
-  Update llvm submodule rust-lang#90954

Additionally, this bumps the stage 0 compiler from beta to stable 1.56.1.

r? `@Mark-Simulacrum`
yvt added a commit to r3-os/r3 that referenced this pull request Dec 4, 2021
@yvt
fix(test_runner): add #![feature(must_not_suspend)]
577db5e 
The `must_not_suspend` lint is now feature-gated by
<rust-lang/rust#89826>.
@tmandry tmandry mentioned this pull request Feb 15, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.

Feature gate the must_not_suspend lint