-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #86853 #89450
Revert #86853 #89450
Conversation
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
For the record, while I'm not going to open my own PR, I was able to get a simpler revert by reverting the merge commit instead of every single commit (eddyb@5345239), using: git revert -m 1 c6007fdc7059c677a6c089e8d2915b264c0d1326 |
Oh, thanks :) |
7204449
to
81bb5a5
Compare
@bors r+ p=1 |
📌 Commit 81bb5a5 has been approved by |
Should I add some sort of regression test like the one mentioned here? If so where should I put it? |
Yea, that seems useful, but it could also wait for the real fix PR. I'm not sure where we have the tests for const trait bounds, but probably in src/test/consts |
✌️ @usbalbin can now approve this pull request |
If the highest prio is getting the revert landed, then I'll wait for another PR/the fix PR. :) |
Co-authored-by: Josh Stone <[email protected]>
@bors r=oli-obk |
📌 Commit 6a0c97a has been approved by |
⌛ Testing commit 6a0c97a with merge b9712854cd6786939d92688a4bbb301d4756fa3e... |
💥 Test timed out |
@bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (a8387ae): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Eliminate ConstnessAnd again Closes rust-lang#91489. Closes rust-lang#89432. Reverts rust-lang#91491. Reverts rust-lang#89450. r? `@spastorino`
Eliminate ConstnessAnd again Closes rust-lang#91489. Closes rust-lang#89432. Reverts rust-lang#91491. Reverts rust-lang#89450. r? `@spastorino`
Should fix issue found in #89432