Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing const edge case #88390

Merged
merged 4 commits into from
Aug 28, 2021
Merged

Add missing const edge case #88390

merged 4 commits into from
Aug 28, 2021

Conversation

roxelo
Copy link
Member

@roxelo roxelo commented Aug 27, 2021

We don't "process" const so we need to check for additional cases when the PatKind is a Path. We need to make sure that if there is only one variant that there is no field. If there is one or more field, we will want to borrow the match scrutinee

Closes #88331
r? @nikomatsakis

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nikomatsakis
Copy link
Contributor

@bors r+ p=1

2021 Edition blocker

@bors
Copy link
Contributor

bors commented Aug 27, 2021

📌 Commit c4dba5a has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2021
@bors
Copy link
Contributor

bors commented Aug 28, 2021

⌛ Testing commit c4dba5a with merge 223d49e13c1b43bf16cfb65deef888bf46da88e4...

@bors
Copy link
Contributor

bors commented Aug 28, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 28, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@ehuss
Copy link
Contributor

ehuss commented Aug 28, 2021

@bors retry
Apple runners failed with no logs.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2021
@bors
Copy link
Contributor

bors commented Aug 28, 2021

⌛ Testing commit c4dba5a with merge 0ff5841509ee59a4331eacfb8f4a67a694cbfd11...

@bors
Copy link
Contributor

bors commented Aug 28, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 28, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@ehuss
Copy link
Contributor

ehuss commented Aug 28, 2021

@bors retry
apple again

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2021
@bors
Copy link
Contributor

bors commented Aug 28, 2021

⌛ Testing commit c4dba5a with merge 42a2a53...

@bors
Copy link
Contributor

bors commented Aug 28, 2021

☀️ Test successful - checks-actions
Approved by: nikomatsakis
Pushing 42a2a53 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 28, 2021
@bors bors merged commit 42a2a53 into rust-lang:master Aug 28, 2021
This was referenced Aug 28, 2021
Closed
Merged
@cuviper cuviper added this to the 1.56.0 milestone Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arora-aman arora-aman arora-aman left review comments

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.

ICE: error with disjoint closure returned as impl FnMut
8 participants
@roxelo @rust-log-analyzer @nikomatsakis @bors @ehuss @arora-aman @cuviper @rust-highfive