Check the number of generic lifetime and const parameters of intrinsics #86148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
crlf0710
added
S-waiting-on-review
varkor
reviewed
Jun 30, 2021
varkor
added
S-waiting-on-author
varkor
reviewed
Jul 1, 2021
|
Thanks, this all looks good to me now! @bors r+ |
|
📌 Commit fe93349 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 1, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#86148 (Check the number of generic lifetime and const parameters of intrinsics) - rust-lang#86659 (fix(rustdoc): generics search) - rust-lang#86768 (Add myself to mailmap) - rust-lang#86775 (Test for const trait impls behind feature gates) - rust-lang#86779 (Allow anyone to add or remove any label starting with perf-) - rust-lang#86783 (Move Mutex::unlock to T: ?Sized) - rust-lang#86785 (proc_macro/bridge: Remove dead code Slice type) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #85855. The current code for type checking intrinsics only checks the number of generic type parameters, but does not check for an incorrect number of lifetime or const parameters, which can cause problems later on, such as the ICE in #85855, where the code thought that it was looking at a type parameter but found a lifetime parameter:
The changes in this PR add checks for the number of lifetime and const parameters, expand the scope of
E0094to also apply to these cases, and improve the error message by properly pluralizing the number of expected generic parameters.