-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RLS #85352
Update RLS #85352
Conversation
|
I had some similar questions about rustfmt after I checked the toolstate page earlier (admittedly a bit prematurely) and noticed that it hadn't been updated in a while either. Not sure if that's expected or related, but sharing in case it is |
What is toolstate upgrade? |
I meant "Toolstate changed!" notifications such as #84886 (comment) |
I guess there's no harm in pushing this further and I believe chances of this needing a follow-up are slim @bors r+ p=1 |
📌 Commit 9235446 has been approved by |
☀️ Test successful - checks-actions |
Tested on commit rust-lang/rust@fa72878. Direct link to PR: <rust-lang/rust#85352> 🎉 rls on windows: build-fail → test-pass (cc @Xanewok). 🎉 rls on linux: build-fail → test-pass (cc @Xanewok).
Contains rust-lang/rls#1736. With #82208 merged, this should now close #85225. Tested locally with
./x.py test src/tools/rls
and seems to be working as expected.I noticed the rustfmt merge didn't trigger toolstate upgrade (because we pruned most but not all of the related machinery?), so I'd rather get this rubber-stamped by someone more knowledgeable with infra/the merged changes in case I missed something and need to include something else here to unbreak the RLS toolstate.
r? @Mark-Simulacrum