avoid converting types into themselves (clippy::useless_conversion) #82236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @lcnr (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jyn514
approved these changes
Feb 17, 2021
| @@ -161,7 +161,7 @@ impl<'tcx> DocContext<'tcx> { | |||
| } | |||
| Entry::Occupied(e) => e.into_mut(), | |||
| }; | |||
| *def_index = DefIndex::from(*def_index + 1); | |||
| *def_index = *def_index + 1; | |||
There was a problem hiding this comment.
Does this compile?
Suggested change
| *def_index = *def_index + 1; | |
| *def_index += 1; |
There was a problem hiding this comment.
nope :(
error[E0368]: binary assignment operation `+=` cannot be applied to type `DefIndex`
--> src/librustdoc/core.rs:164:9
|
164 | *def_index += 1;
| ----------^^^^^
| |
| cannot use `+=` on type `DefIndex`
There was a problem hiding this comment.
Now I'm confused, how does this code work at all? DefIndex implements neither Deref nor Add: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir/def_id/struct.DefIndex.html
There was a problem hiding this comment.
Could be related to the newtype_index!() macro that is used when the struct is declared
https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_span/def_id.rs.html#119
https://doc.rust-lang.org/nightly/nightly-rustc/rustc_index/macro.newtype_index.html
There was a problem hiding this comment.
Ah, ok. It would be nice to add AddAssign there. But no need to do it here.
jyn514
added
C-cleanup
|
@bors r+ |
|
📌 Commit ec50a20 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 18, 2021
avoid converting types into themselves (clippy::useless_conversion)
This was referenced Feb 18, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 18, 2021
Rollup of 10 pull requests Successful merges: - rust-lang#81546 ([libtest] Run the test synchronously when hitting thread limit) - rust-lang#82066 (Ensure valid TraitRefs are created for GATs) - rust-lang#82112 (const_generics: Dont evaluate array length const when handling yet another error ) - rust-lang#82194 (In some limited cases, suggest `where` bounds for non-type params) - rust-lang#82215 (Replace if-let and while-let with `if let` and `while let`) - rust-lang#82218 (Make sure pdbs are copied along with exe and dlls when bootstrapping) - rust-lang#82236 (avoid converting types into themselves (clippy::useless_conversion)) - rust-lang#82246 (Add long explanation for E0549) - rust-lang#82248 (Optimize counting digits in line numbers during error reporting) - rust-lang#82256 (Print -Ztime-passes (and misc stats/logs) on stderr, not stdout.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.