Pass large interpreter types by reference, not value

[tmiasko]

r? @ghost

[tmiasko]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 2f848d16c713221f16669cdc9f26e3475f0e853f with merge 0e02f3685d46b23771eab0f3e32ad5c642674b72...

[bors]

☀️ Try build successful - checks-actions
Build commit: 0e02f3685d46b23771eab0f3e32ad5c642674b72 (0e02f3685d46b23771eab0f3e32ad5c642674b72)

[rust-timer]

Queued 0e02f3685d46b23771eab0f3e32ad5c642674b72 with parent 9503ea1, future comparison URL.

[rust-timer]

Finished benchmarking try commit (0e02f3685d46b23771eab0f3e32ad5c642674b72): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

[tmiasko]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 5c07b11d3f4f488fa22cd84f9cb7896b7d5510c1 with merge 8a56338175f5895c206e36b88ef2a54b7431ba55...

[bors]

☀️ Try build successful - checks-actions
Build commit: 8a56338175f5895c206e36b88ef2a54b7431ba55 (8a56338175f5895c206e36b88ef2a54b7431ba55)

[rust-timer]

Queued 8a56338175f5895c206e36b88ef2a54b7431ba55 with parent 9503ea1, future comparison URL.

[rust-timer]

Finished benchmarking try commit (8a56338175f5895c206e36b88ef2a54b7431ba55): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

[tmiasko]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit f32efec494af50c0af25fd141126b1c3b553a4fd with merge 94eba4a15a544415ce0127f932e91a67230e460d...

[bors]

☀️ Try build successful - checks-actions
Build commit: 94eba4a15a544415ce0127f932e91a67230e460d (94eba4a15a544415ce0127f932e91a67230e460d)

[bors]

⌛ Testing commit f2da425 with merge fe6b31cd5e1d5b2c089f6f3f242c3c925062a079...

[tmiasko]

@RalfJung I can make the appropriate changes in miri after this lands.

It appears the CI will time out on i686-gnu-nopt builder once again #82221, though :-(.

[bors]

💥 Test timed out

[RalfJung]

@bors retry

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[bors]

⌛ Testing commit f2da425 with merge 2ce5bf004705ce261a9be0a58352a86269dacf3d...

[bors]

💥 Test timed out

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RalfJung]

@bors retry

[bors]

⌛ Testing commit f2da425 with merge e7c23ab...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing e7c23ab to master...

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at e7c23ab93 Auto merge of #82124 - tmiasko:op-ty-ref, r=oli-obk
##[group]Run src/ci/publish_toolstate.sh
src/ci/publish_toolstate.sh
env:
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  DEPLOY_BUCKET: rust-lang-ci2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
  CACHE_DOMAIN: ci-caches.rust-lang.org
  TOOLSTATE_REPO_ACCESS_TOKEN: ***
##[endgroup]
Cloning into 'rust-toolstate'...
/home/runner/work/rust/rust/src/tools/publish_toolstate.py:121: DeprecationWarning: 'U' mode is deprecated
📣 Toolstate changed by rust-lang/rust#82124!
  with open(path, 'rU') as f:

Tested on commit rust-lang/rust@e7c23ab933ebc1f205c3b59f4ebc85d40f67d404.
Direct link to PR: <https://github.com/rust-lang/rust/pull/82124>

💔 miri on windows: test-fail → build-fail (cc @RalfJung @eddyb @oli-obk).
💔 miri on linux: test-fail → build-fail (cc @RalfJung @eddyb @oli-obk).
Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/runner/work/rust/rust/src/tools/publish_toolstate.py", line 338, in <module>
    response = urllib2.urlopen(urllib2.Request(
  File "/usr/lib/python3.8/urllib/request.py", line 222, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.8/urllib/request.py", line 522, in open
    req = meth(req)
  File "/usr/lib/python3.8/urllib/request.py", line 1281, in do_request_
    raise TypeError(msg)
TypeError: POST data should be bytes, an iterable of bytes, or a file object. It cannot be of type str.
##[error]Process completed with exit code 1.