Rollup of 11 pull requests #82103
Merged
Rollup of 11 pull requests #82103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h Function and Method.
The information logged here is of limited general interest, while at the same times makes it impractical to simply enable logging and share the resulting logs due to the amount of the output produced. Reduce log level from info to debug for developer oriented information. For example, when building cargo, this reduces the amount of logs generated by `RUSTC_LOG=info cargo build` from 265 MB to 79 MB. Continuation of changes from 81350.
#[doc(inline)] sym_generated Manually doc-inlines `rustc_span::sym_generated` into `sym`. Previously the docs would not get inlined, causing the symbols to be undocumented as `sym_generated` is private. r? `@jyn514`
Visit more targets when validating attributes This begins to address rust-lang#80048, allowing for additional validation of attributes. There are more refactorings that can be done, though I think they should be tackled in additional PRs: * ICE when a builtin attribute is encountered that is not checked * Move some of the attr checking done `ast_validation` into `rustc_passes` * note that this requires a bit of additional refactoring, especially of extern items which currently parse attributes (and thus are a part of the AST) but do not possess attributes in their HIR representation. * Rename `Target` to `AttributeTarget` * Refactor attribute validation completely to go through `Visitor::visit_attribute`. * This would require at a minimum passing `Target` into this method which might be too big of a refactoring to be worth it. * It's also likely not possible to do all the validation this way as some validation requires knowing what other attributes a target has. r? `@davidtwco`
…lacrum Updated smallvec version due to RUSTSEC-2021-0003 Hi. Updated Cargo.toml's for smallvec due to RUSTSEC-2021-0003 and Cargo.toml in separate commit. Affected function `SmallVec::insert_many` looks like don't was used directly in rust, but can be somewhere in deps. There should be some mechanism to not to do this kind of things manually, like dependabot. Actually, dependabot supports rust and can check security articles (at least that noted in description).
[rustdoc-json] Make `header` a vec of modifiers, and FunctionPointer consistent Bumps version number and adds tests, this is a breaking change. I can split this into two (`is_unsafe` -> `header` and `header: Vec<Modifiers>`) if desired. Rationale: Modifiers are individual notes on a function, it makes more sense for them to be a list of an independent enum over a String which is inconsistently exposing the HIR representation (prefix_str vs custom literals). Function pointers currently only support `unsafe`, but there has been talk on and off about allowing them to also support `const`, and this makes handling their modifiers consistent with handling those of a function, allowing better shared code. `@rustbot` modify labels: +A-rustdoc-json +T-rustdoc CC: `@HeroicKatora` r? `@jyn514`
…ikomatsakis Implement the precise analysis pass for lint `disjoint_capture_drop_reorder` The precision pass for the lint prevents the lint from triggering for a variable (that was previously entirely captured by the closure) if all paths that need Drop starting at root variable have been captured by the closure. r? `@nikomatsakis`
Fixing bad suggestion for `_` in `const` type when a function rust-lang#81885 Closes rust-lang#81885 ``` error[E0121]: the type placeholder `_` is not allowed within types on item signatures --> $DIR/typeck_type_placeholder_item_help.rs:13:22 | LL | const TEST4: fn() -> _ = 42; | ^ | | | not allowed in type signatures | help: use type parameters instead: `T` ``` Do not show the suggestion `help: use type parameters instead: T` when `fn`
…ark-Simulacrum BTreeMap: fix internal comments Salvaged from rust-lang#81372 r? `@Mark-Simulacrum`
…mulacrum Add a regression test for rust-lang#32498 [This](rust-lang#32498 (comment)) test mentioned at issue rust-lang#32498 now passes. This PR adds this regression test.
Fix MIR pretty printer for non-local DefIds Tries to fix rust-lang#81200 -- the reproducer in the issue is not fixed yet. Submitting PR to get feedback. r? oli-obk
Use debug log level for developer oriented logs The information logged here is of limited general interest, while at the same times makes it impractical to simply enable logging and share the resulting logs due to the amount of the output produced. Reduce log level from info to debug for developer oriented information. For example, when building cargo, this reduces the amount of logs generated by `RUSTC_LOG=info cargo build` from 265 MB to 79 MB. Continuation of changes from 81350.
|
@bors r+ rollup=never p=5 |
|
📌 Commit bcb1403 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit bcb1403 with merge 4a2263375d90413870e37856eeae2da5a5f542c0... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Feb 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
headera vec of modifiers, and FunctionPointer consistent #81891 ([rustdoc-json] Makeheadera vec of modifiers, and FunctionPointer consistent)disjoint_capture_drop_reorder#81912 (Implement the precise analysis pass for lintdisjoint_capture_drop_reorder)_inconsttype when a function #81885 #81914 (Fixing bad suggestion for_inconsttype when a function Bad suggestion for_inconsttype #81885)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup