Try fast_reject::simplify_type in coherence before doing full check #81744

rylev · 2021-02-04T09:57:23Z

This is a reattempt at landing #69010 (by @jonas-schievink). The change adds a fast path for coherence checking to see if there's no way for types to unify since full coherence checking can be somewhat expensive.

This has big effects on code generated by the windows which in some cases spends as much as 20% of compilation time in the specialization_graph_of query. In local benchmarks this took a compilation that previously took ~500 seconds down to ~380 seconds.

This is surely not going to make a difference on much smaller crates, so the question is whether it will have a negative impact. #69010 was closed because some of the perf suite crates did show small regressions.

Additional discussion of this issue is happening here.

Co-authored-by: Jonas Schievink <[email protected]> Co-authored-by: Ryan Levick <[email protected]>

rust-highfive · 2021-02-04T09:57:25Z

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

rylev · 2021-02-04T09:57:30Z

@bors try @rust-timer queue

rust-timer · 2021-02-04T09:57:32Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-02-04T09:57:59Z

⌛ Trying commit cdfc52f with merge 314cb49364173f1ac3a9566663aabfd4d22446c5...

bors · 2021-02-04T10:43:53Z

☀️ Try build successful - checks-actions
Build commit: 314cb49364173f1ac3a9566663aabfd4d22446c5 (314cb49364173f1ac3a9566663aabfd4d22446c5)

rust-timer · 2021-02-04T10:43:55Z

Queued 314cb49364173f1ac3a9566663aabfd4d22446c5 with parent e708cbd, future comparison URL.

rust-timer · 2021-02-04T12:22:52Z

Finished benchmarking try commit (314cb49364173f1ac3a9566663aabfd4d22446c5): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

rylev · 2021-02-04T12:43:37Z

The perf regression looks better here than in #69010 - only impacting packed-simd. The only regression over 1% is packed-simd-doc which has a 2.4% increase in the specialization_graph_of query and 1.5% increase in overall compilation time. Basically all other benchmarks besides the various packed-simd ones are unaffected or are small perf gains.

Mark-Simulacrum · 2021-02-04T12:55:57Z

IMO the regressions in this PR are entirely acceptable given the (unfortunately not yet tracked) huge wins we're seeing on some crates, such as windows-rs.

rylev · 2021-02-04T13:36:50Z

I did some benchmarking on the packed-simd case. It seems there that the optimization successfully short-circuits the larger coherence check ~13% of the time. Coherence checking is a larger percentage of time in the docs case which is why this is extra pronounced in the docs compilation. The windows-rs benchmark triggers the shortcutting over 99% of the time so it's much more useful.

This makes sense as in the worst case scenario this change will only add to the time it takes to do coherence checking. The question is how often this shortcut will trigger in the average case.

lcnr

this does not reject impl Trait for &u32 and impl Trait for u32 because simplify_type was originally intended to be used in typeck where we look into references.

Does the hitrate go up if you extend simplify_type to optionally emit another variant for references?

…erent reference mutability

rylev · 2021-02-12T13:04:39Z

Queuing another performance run.

@bors try @rust-timer queue

rust-timer · 2021-02-12T13:04:41Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-02-12T13:04:53Z

⌛ Trying commit 8ea0973 with merge f2b99ebaa9ac47c7c5517292248ebacb6b125186...

bors · 2021-02-12T14:05:19Z

☀️ Try build successful - checks-actions
Build commit: f2b99ebaa9ac47c7c5517292248ebacb6b125186 (f2b99ebaa9ac47c7c5517292248ebacb6b125186)

rust-timer · 2021-02-12T14:05:21Z

Queued f2b99ebaa9ac47c7c5517292248ebacb6b125186 with parent a118ee2, future comparison URL.

rust-timer · 2021-02-12T16:03:47Z

Finished benchmarking try commit (f2b99ebaa9ac47c7c5517292248ebacb6b125186): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

rylev · 2021-02-12T16:12:40Z

@lcnr perf looks relatively the same after the latest push (albeit a tiny bit worse - though this might be noise). Interestingly when I build the packed-simd benchmark locally, this PR's build is almost always faster (though maybe not statistically significantly so).

compiler/rustc_trait_selection/src/traits/coherence.rs

lcnr · 2021-02-12T16:42:29Z

@bors r+ rollup=never

bors · 2021-02-12T16:42:30Z

📌 Commit 0cc35f5 has been approved by lcnr

bors · 2021-02-12T17:38:20Z

⌛ Testing commit 0cc35f5 with merge 3f5aee2...

bors · 2021-02-12T20:40:44Z

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 3f5aee2 to master...

Package changes: * bump bootstraps to 1.51.0. * adjust patches and cargo checksums as required * 1.51 failed to build natively on 32-bit armv7, there is hope that this is fixed with 1.52. (1.51 can be built with netbsd32 emulation on a aarch64 system). Upsteream changes: Version 1.52.0 (2021-05-06) ============================ Language -------- - [Added the `unsafe_op_in_unsafe_fn` lint, which checks whether the unsafe code in an `unsafe fn` is wrapped in a `unsafe` block.][79208] This lint is allowed by default, and may become a warning or hard error in a future edition. - [You can now cast mutable references to arrays to a pointer of the same type as the element.][81479] Compiler -------- - [Upgraded the default LLVM to LLVM 12.][81451] Added tier 3\* support for the following targets. - [`s390x-unknown-linux-musl`][82166] - [`riscv32gc-unknown-linux-musl` & `riscv64gc-unknown-linux-musl`][82202] - [`powerpc-unknown-openbsd`][82733] \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [`OsString` now implements `Extend` and `FromIterator`.][82121] - [`cmp::Reverse` now has `#[repr(transparent)]` representation.][81879] - [`Arc<impl Error>` now implements `error::Error`.][80553] - [All integer division and remainder operations are now `const`.][80962] Stabilised APIs ------------- - [`Arguments::as_str`] - [`char::MAX`] - [`char::REPLACEMENT_CHARACTER`] - [`char::UNICODE_VERSION`] - [`char::decode_utf16`] - [`char::from_digit`] - [`char::from_u32_unchecked`] - [`char::from_u32`] - [`slice::partition_point`] - [`str::rsplit_once`] - [`str::split_once`] The following previously stable APIs are now `const`. - [`char::len_utf8`] - [`char::len_utf16`] - [`char::to_ascii_uppercase`] - [`char::to_ascii_lowercase`] - [`char::eq_ignore_ascii_case`] - [`u8::to_ascii_uppercase`] - [`u8::to_ascii_lowercase`] - [`u8::eq_ignore_ascii_case`] Rustdoc ------- - [Rustdoc lints are now treated as a tool lint, meaning that lints are now prefixed with `rustdoc::` (e.g. `#[warn(rustdoc::non_autolinks)]`).][80527] Using the old style is still allowed, and will become a warning in a future release. - [Rustdoc now supports argument files.][82261] - [Rustdoc now generates smart punctuation for documentation.][79423] - [You can now use "task lists" in Rustdoc Markdown.][81766] E.g. ```markdown - [x] Complete - [ ] Todo ``` Misc ---- - [You can now pass multiple filters to tests.][81356] E.g. `cargo test -- foo bar` will run all tests that match `foo` and `bar`. - [Rustup now distributes PDB symbols for the `std` library on Windows, allowing you to see `std` symbols when debugging.][82218] Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Check the result cache before the DepGraph when ensuring queries][81855] - [Try fast_reject::simplify_type in coherence before doing full check][81744] - [Only store a LocalDefId in some HIR nodes][81611] - [Store HIR attributes in a side table][79519] Compatibility Notes ------------------- - [Cargo build scripts are now forbidden from setting `RUSTC_BOOTSTRAP`.] [cargo/9181] - [Removed support for the `x86_64-rumprun-netbsd` target.][82594] - [Deprecated the `x86_64-sun-solaris` target in favor of `x86_64-pc-solaris`.] [82216] - [Rustdoc now only accepts `,`, ` `, and `\t` as delimiters for specifying languages in code blocks.][78429] - [Rustc now catches more cases of `pub_use_of_private_extern_crate`][80763] - [Changes in how proc macros handle whitespace may lead to panics when used with older `proc-macro-hack` versions. A `cargo update` should be sufficient to fix this in all cases.][84136] [84136]: rust-lang/rust#84136 [80763]: rust-lang/rust#80763 [82166]: rust-lang/rust#82166 [82121]: rust-lang/rust#82121 [81879]: rust-lang/rust#81879 [82261]: rust-lang/rust#82261 [82218]: rust-lang/rust#82218 [82216]: rust-lang/rust#82216 [82202]: rust-lang/rust#82202 [81855]: rust-lang/rust#81855 [81766]: rust-lang/rust#81766 [81744]: rust-lang/rust#81744 [81611]: rust-lang/rust#81611 [81479]: rust-lang/rust#81479 [81451]: rust-lang/rust#81451 [81356]: rust-lang/rust#81356 [80962]: rust-lang/rust#80962 [80553]: rust-lang/rust#80553 [80527]: rust-lang/rust#80527 [79519]: rust-lang/rust#79519 [79423]: rust-lang/rust#79423 [79208]: rust-lang/rust#79208 [78429]: rust-lang/rust#78429 [82733]: rust-lang/rust#82733 [82594]: rust-lang/rust#82594 [cargo/9181]: rust-lang/cargo#9181 [`char::MAX`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.MAX [`char::REPLACEMENT_CHARACTER`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.REPLACEMENT_CHARACTER [`char::UNICODE_VERSION`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.UNICODE_VERSION [`char::decode_utf16`]: https://doc.rust-lang.org/std/primitive.char.html#method.decode_utf16 [`char::from_u32`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32 [`char::from_u32_unchecked`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32_unchecked [`char::from_digit`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_digit [`Peekable::next_if`]: https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if [`Peekable::next_if_eq`]: https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if_eq [`Arguments::as_str`]: https://doc.rust-lang.org/stable/std/fmt/struct.Arguments.html#method.as_str [`str::split_once`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.split_once [`str::rsplit_once`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.rsplit_once [`slice::partition_point`]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.partition_point [`char::len_utf8`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.len_utf8 [`char::len_utf16`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.len_utf16 [`char::to_ascii_uppercase`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_ascii_uppercase [`char::to_ascii_lowercase`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_ascii_lowercase [`char::eq_ignore_ascii_case`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.eq_ignore_ascii_case [`u8::to_ascii_uppercase`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.to_ascii_uppercase [`u8::to_ascii_lowercase`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.to_ascii_lowercase [`u8::eq_ignore_ascii_case`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.eq_ignore_ascii_case

Pkgsrc changes: * Bump bootstrap kit version to 1.51.0. * Adjust patches as needed. * Update checksum adjustments. * Fix syntax error in commands adjusting libserde_derive for Darwin Upstream changes: Version 1.52.1 (2021-05-10) ============================ This release disables incremental compilation, unless the user has explicitly opted in via the newly added RUSTC_FORCE_INCREMENTAL=1 environment variable. This is due to the widespread, and frequently occuring, breakage encountered by Rust users due to newly enabled incremental verification in 1.52.0. Notably, Rust users **should** upgrade to 1.52.0 or 1.52.1: the bugs that are detected by newly added incremental verification are still present in past stable versions, and are not yet fixed on any channel. These bugs can lead to miscompilation of Rust binaries. These problems only affect incremental builds, so release builds with Cargo should not be affected unless the user has explicitly opted into incremental. Debug and check builds are affected. See [84970] for more details. [84970]: rust-lang/rust#84970 Version 1.52.0 (2021-05-06) ============================ Language -------- - [Added the `unsafe_op_in_unsafe_fn` lint, which checks whether the unsafe code in an `unsafe fn` is wrapped in a `unsafe` block.][79208] This lint is allowed by default, and may become a warning or hard error in a future edition. - [You can now cast mutable references to arrays to a pointer of the same type as the element.][81479] Compiler -------- - [Upgraded the default LLVM to LLVM 12.][81451] Added tier 3\* support for the following targets. - [`s390x-unknown-linux-musl`][82166] - [`riscv32gc-unknown-linux-musl` & `riscv64gc-unknown-linux-musl`][82202] - [`powerpc-unknown-openbsd`][82733] \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [`OsString` now implements `Extend` and `FromIterator`.][82121] - [`cmp::Reverse` now has `#[repr(transparent)]` representation.][81879] - [`Arc<impl Error>` now implements `error::Error`.][80553] - [All integer division and remainder operations are now `const`.][80962] Stabilised APIs ------------- - [`Arguments::as_str`] - [`char::MAX`] - [`char::REPLACEMENT_CHARACTER`] - [`char::UNICODE_VERSION`] - [`char::decode_utf16`] - [`char::from_digit`] - [`char::from_u32_unchecked`] - [`char::from_u32`] - [`slice::partition_point`] - [`str::rsplit_once`] - [`str::split_once`] The following previously stable APIs are now `const`. - [`char::len_utf8`] - [`char::len_utf16`] - [`char::to_ascii_uppercase`] - [`char::to_ascii_lowercase`] - [`char::eq_ignore_ascii_case`] - [`u8::to_ascii_uppercase`] - [`u8::to_ascii_lowercase`] - [`u8::eq_ignore_ascii_case`] Rustdoc ------- - [Rustdoc lints are now treated as a tool lint, meaning that lints are now prefixed with `rustdoc::` (e.g. `#[warn(rustdoc::non_autolinks)]`).][80527] Using the old style is still allowed, and will become a warning in a future release. - [Rustdoc now supports argument files.][82261] - [Rustdoc now generates smart punctuation for documentation.][79423] - [You can now use "task lists" in Rustdoc Markdown.][81766] E.g. ```markdown - [x] Complete - [ ] Todo ``` Misc ---- - [You can now pass multiple filters to tests.][81356] E.g. `cargo test -- foo bar` will run all tests that match `foo` and `bar`. - [Rustup now distributes PDB symbols for the `std` library on Windows, allowing you to see `std` symbols when debugging.][82218] Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Check the result cache before the DepGraph when ensuring queries][81855] - [Try fast_reject::simplify_type in coherence before doing full check][81744] - [Only store a LocalDefId in some HIR nodes][81611] - [Store HIR attributes in a side table][79519] Compatibility Notes ------------------- - [Cargo build scripts are now forbidden from setting `RUSTC_BOOTSTRAP`.][cargo/9181] - [Removed support for the `x86_64-rumprun-netbsd` target.][82594] - [Deprecated the `x86_64-sun-solaris` target in favor of `x86_64-pc-solaris`.][82216] - [Rustdoc now only accepts `,`, ` `, and `\t` as delimiters for specifying languages in code blocks.][78429] - [Rustc now catches more cases of `pub_use_of_private_extern_crate`][80763] - [Changes in how proc macros handle whitespace may lead to panics when used with older `proc-macro-hack` versions. A `cargo update` should be sufficient to fix this in all cases.][84136] [84136]: rust-lang/rust#84136 [80763]: rust-lang/rust#80763 [82166]: rust-lang/rust#82166 [82121]: rust-lang/rust#82121 [81879]: rust-lang/rust#81879 [82261]: rust-lang/rust#82261 [82218]: rust-lang/rust#82218 [82216]: rust-lang/rust#82216 [82202]: rust-lang/rust#82202 [81855]: rust-lang/rust#81855 [81766]: rust-lang/rust#81766 [81744]: rust-lang/rust#81744 [81611]: rust-lang/rust#81611 [81479]: rust-lang/rust#81479 [81451]: rust-lang/rust#81451 [81356]: rust-lang/rust#81356 [80962]: rust-lang/rust#80962 [80553]: rust-lang/rust#80553 [80527]: rust-lang/rust#80527 [79519]: rust-lang/rust#79519 [79423]: rust-lang/rust#79423 [79208]: rust-lang/rust#79208 [78429]: rust-lang/rust#78429 [82733]: rust-lang/rust#82733 [82594]: rust-lang/rust#82594 [cargo/9181]: rust-lang/cargo#9181 [`char::MAX`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.MAX [`char::REPLACEMENT_CHARACTER`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.REPLACEMENT_CHARACTER [`char::UNICODE_VERSION`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.UNICODE_VERSION [`char::decode_utf16`]: https://doc.rust-lang.org/std/primitive.char.html#method.decode_utf16 [`char::from_u32`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32 [`char::from_u32_unchecked`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32_unchecked [`char::from_digit`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_digit [`Peekable::next_if`]: https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if [`Peekable::next_if_eq`]: https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if_eq [`Arguments::as_str`]: https://doc.rust-lang.org/stable/std/fmt/struct.Arguments.html#method.as_str [`str::split_once`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.split_once [`str::rsplit_once`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.rsplit_once [`slice::partition_point`]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.partition_point [`char::len_utf8`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.len_utf8 [`char::len_utf16`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.len_utf16 [`char::to_ascii_uppercase`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_ascii_uppercase [`char::to_ascii_lowercase`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_ascii_lowercase [`char::eq_ignore_ascii_case`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.eq_ignore_ascii_case [`u8::to_ascii_uppercase`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.to_ascii_uppercase [`u8::to_ascii_lowercase`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.to_ascii_lowercase [`u8::eq_ignore_ascii_case`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.eq_ignore_ascii_case

Try fast_reject::simplify_type in coherence before doing full check

cdfc52f

Co-authored-by: Jonas Schievink <[email protected]> Co-authored-by: Ryan Levick <[email protected]>

rust-highfive assigned lcnr Feb 4, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 4, 2021

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 4, 2021

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 4, 2021

lcnr reviewed Feb 6, 2021

View reviewed changes

jonas-schievink added relnotes-perf Performance improvements that should be mentioned in the release notes. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 9, 2021

Short circuit full corherence check when dealing with types with diff…

8ea0973

…erent reference mutability

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 12, 2021

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 12, 2021

Switch boolean checks

bc5f4c4

lcnr reviewed Feb 12, 2021

View reviewed changes

compiler/rustc_trait_selection/src/traits/coherence.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Don't check self type twice

0cc35f5

rylev force-pushed the overlapping-early-exit2 branch from 35add42 to 0cc35f5 Compare February 12, 2021 16:37

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 12, 2021

bors merged commit 3f5aee2 into rust-lang:master Feb 12, 2021

rustbot added this to the 1.52.0 milestone Feb 12, 2021

rylev deleted the overlapping-early-exit2 branch February 15, 2021 09:37

hkratz mentioned this pull request Mar 6, 2022

Binary crashes when statically linked with LTO turned on #94564

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try fast_reject::simplify_type in coherence before doing full check #81744

Try fast_reject::simplify_type in coherence before doing full check #81744

rylev commented Feb 4, 2021 •

edited

Loading

rust-highfive commented Feb 4, 2021

rylev commented Feb 4, 2021

rust-timer commented Feb 4, 2021

bors commented Feb 4, 2021

bors commented Feb 4, 2021

rust-timer commented Feb 4, 2021

rust-timer commented Feb 4, 2021

rylev commented Feb 4, 2021 •

edited

Loading

Mark-Simulacrum commented Feb 4, 2021

rylev commented Feb 4, 2021

lcnr left a comment

rylev commented Feb 12, 2021

rust-timer commented Feb 12, 2021

bors commented Feb 12, 2021

bors commented Feb 12, 2021

rust-timer commented Feb 12, 2021

rust-timer commented Feb 12, 2021

rylev commented Feb 12, 2021

This comment has been minimized.

lcnr commented Feb 12, 2021

bors commented Feb 12, 2021

bors commented Feb 12, 2021

bors commented Feb 12, 2021

Try fast_reject::simplify_type in coherence before doing full check #81744

Try fast_reject::simplify_type in coherence before doing full check #81744

Conversation

rylev commented Feb 4, 2021 • edited Loading

rust-highfive commented Feb 4, 2021

rylev commented Feb 4, 2021

rust-timer commented Feb 4, 2021

bors commented Feb 4, 2021

bors commented Feb 4, 2021

rust-timer commented Feb 4, 2021

rust-timer commented Feb 4, 2021

rylev commented Feb 4, 2021 • edited Loading

Mark-Simulacrum commented Feb 4, 2021

rylev commented Feb 4, 2021

lcnr left a comment

Choose a reason for hiding this comment

rylev commented Feb 12, 2021

rust-timer commented Feb 12, 2021

bors commented Feb 12, 2021

bors commented Feb 12, 2021

rust-timer commented Feb 12, 2021

rust-timer commented Feb 12, 2021

rylev commented Feb 12, 2021

This comment has been minimized.

lcnr commented Feb 12, 2021

bors commented Feb 12, 2021

bors commented Feb 12, 2021

bors commented Feb 12, 2021

rylev commented Feb 4, 2021 •

edited

Loading

rylev commented Feb 4, 2021 •

edited

Loading