-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
always eagerly eval consts in Relate #81309
Conversation
@@ -1,11 +1,11 @@ | |||
error[E0308]: mismatched types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without this PR, this test causes the following output:
error[E0308]: mismatched types
--> $DIR/const-argument-cross-crate-mismatch.rs:9:67
|
LL | let _ = const_generic_lib::function(const_generic_lib::Struct([0u8, 1u8]));
| ^^^^^^^^^^ expected `3_usize`, found `2_usize`
|
= note: expected array `[u8; 3]`
found array `[u8; 2]`
error[E0308]: mismatched types
--> $DIR/const-argument-cross-crate-mismatch.rs:11:65
|
LL | let _: const_generic_lib::Alias = const_generic_lib::Struct([0u8, 1u8, 2u8]);
| ^^^^^^^^^^^^^^^ expected `2_usize`, found `3_usize`
|
= note: expected array `[u8; 2]`
found array `[u8; 3]`
error: aborting due to 2 previous errors
@nikomatsakis any updates on this? |
So...I'm not 100% sure what I think about this, mostly because I feel like i'm lacking overall context about the "plan", but given that it seems to only affect code that opts into lazy-norm of constants... @bors r+ |
📌 Commit 2beea2c has been approved by |
…akis always eagerly eval consts in Relate r? `@nikomatsakis` cc `@varkor`
…akis always eagerly eval consts in Relate r? ``@nikomatsakis`` cc ``@varkor``
Rollup of 9 pull requests Successful merges: - rust-lang#81309 (always eagerly eval consts in Relate) - rust-lang#82217 (Edition-specific preludes) - rust-lang#82807 (rustdoc: Remove redundant enableSearchInput function) - rust-lang#82924 (WASI: Switch to crt1-command.o to enable support for new-style commands) - rust-lang#82949 (Do not attempt to unlock envlock in child process after a fork.) - rust-lang#82955 (fix: wrong word) - rust-lang#82962 (Treat header as first paragraph for shortened markdown descriptions) - rust-lang#82976 (fix error message for copy(_nonoverlapping) overflow) - rust-lang#82977 (Rename `Option::get_or_default` to `get_or_insert_default`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
r? @nikomatsakis cc @varkor