-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing commas to rustc_ast_pretty::pp
docs
#80457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
added
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
A-pretty
Area: Pretty printing (including `-Z unpretty`)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
A-docs
Area: documentation for any part of the project, including the compiler, standard library, and tools
labels
Dec 28, 2020
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 28, 2020
@bors r+ rollup |
📌 Commit 8d5dc8c has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 28, 2020
Wow, that was a fast |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 29, 2020
…-schievink Add missing commas to `rustc_ast_pretty::pp` docs
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 30, 2020
…-schievink Add missing commas to `rustc_ast_pretty::pp` docs
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 30, 2020
Rollup of 13 pull requests Successful merges: - rust-lang#79812 (Lint on redundant trailing semicolon after item) - rust-lang#80348 (remove redundant clones (clippy::redundant_clone)) - rust-lang#80358 (Edit rustc_span documentation) - rust-lang#80457 (Add missing commas to `rustc_ast_pretty::pp` docs) - rust-lang#80461 (Add llvm-libunwind change to bootstrap CHANGELOG) - rust-lang#80464 (Use Option::map_or instead of open coding it) - rust-lang#80465 (Fix typo in ffi-pure.md) - rust-lang#80467 (More uses of the matches! macro) - rust-lang#80469 (Fix small typo in time comment) - rust-lang#80472 (Use sans-serif font for the "all items" page links) - rust-lang#80477 (Make forget intrinsic safe) - rust-lang#80482 (don't clone copy types) - rust-lang#80487 (don't redundantly repeat field names) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-docs
Area: documentation for any part of the project, including the compiler, standard library, and tools
A-pretty
Area: Pretty printing (including `-Z unpretty`)
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.