Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clone_from from hashbrown::{HashMap,HashSet}. #80400

Merged
merged 1 commit into from
Dec 27, 2020

Conversation

adlerd
Copy link

@adlerd adlerd commented Dec 27, 2020

This change updates the std hash collections to use hashbrown's clone_from, which was itself added in #70052. Deriving Clone does not add a clone_from impl and uses the trait default, which calls clone.

Fixes #28481

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @withoutboats (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 27, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Dec 27, 2020

📌 Commit 7adeb71 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2020
@bors
Copy link
Contributor

bors commented Dec 27, 2020

⌛ Testing commit 7adeb71 with merge 0f42d47...

@bors
Copy link
Contributor

bors commented Dec 27, 2020

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 0f42d47 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 27, 2020
@bors bors merged commit 0f42d47 into rust-lang:master Dec 27, 2020
@rustbot rustbot added this to the 1.51.0 milestone Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clone_from in the standard library
6 participants