-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace run_compiler with RunCompiler builder pattern #77649
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matthewjasper (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
It seems you're adding |
r? @bjorn3 |
@dash2507 for help with git, take a look at https://rustc-dev-guide.rust-lang.org/git.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after removing the compiler/rustc_driver/target dir. I don't have bors permission though.
@bors delegate=bjorn3 |
✌️ @bjorn3 can now approve this pull request |
@dash2507 do you mind squashing the git history so rust doesn't have thousands of build files in the git history? It will make the repo even slower to download for everyone. https://rustc-dev-guide.rust-lang.org/git.html#advanced-rebasing |
b488f70
to
43cde10
Compare
05fda01
to
3e04e46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to edit the commit message to be more descriptive. For example you could use just the PR title. Looking at https://forge.rust-lang.org/index.html it seems that the no tool breakage week has ended yesterday.
3e04e46
to
75c007b
Compare
RunCompiler::new takes non-optional params, and optional params can be set using set_*field_name* method. finally `run` will forward all fields to `run_compiler`.
8632dde
to
e8dca78
Compare
@bors r+ |
📌 Commit e8dca78 has been approved by |
☀️ Test successful - checks-actions, checks-azure |
📣 Toolstate changed by #77649! Tested on commit 25d2d09. 💔 miri on windows: test-fail → build-fail (cc @oli-obk @eddyb @RalfJung). |
Tested on commit rust-lang/rust@25d2d09. Direct link to PR: <rust-lang/rust#77649> 💔 miri on windows: test-fail → build-fail (cc @oli-obk @eddyb @RalfJung). 💔 miri on linux: test-fail → build-fail (cc @oli-obk @eddyb @RalfJung). 💔 rls on windows: test-pass → build-fail (cc @Xanewok). 💔 rls on linux: test-pass → build-fail (cc @Xanewok).
…hewjasper Replace run_compiler with RunCompiler builder pattern Fixes rust-lang#77286. Replaces rustc_driver:run_compiler with RunCompiler builder pattern.
…ulacrum [beta] next This backports: * Avoid installing external LLVM dylibs rust-lang#78986 * Install CI llvm into the library directory rust-lang#79074 * Revert "Revert "resolve: Avoid "self-confirming" import resolutions in one more case"" rust-lang#78784 * Bump Rustfmt and RLS rust-lang#78775 * Enforce no-move rule of ReentrantMutex using Pin and fix UB in stdio rust-lang#77801 For RLS/rustfmt compilation to succeed: * change the order of type arguments on ControlFlow rust-lang#76614 * Add ControlFlow::is_{break,continue} methods rust-lang#78200 * Replace run_compiler with RunCompiler builder pattern rust-lang#77649 As a dependency of rust-lang#77801: * Add Pin::static_ref, static_mut. rust-lang#77726
Fixes #77286. Replaces rustc_driver:run_compiler with RunCompiler builder pattern.