Support static linking with glibc and target-feature=+crt-static #77386

joshtriplett · 2020-10-01T04:29:36Z

With this change, it's possible to build on a linux-gnu target and pass
RUSTFLAGS='-C target-feature=+crt-static' or the equivalent via a
.cargo/config.toml file, and get a statically linked executable.

Update to libc 0.2.78, which adds support for static linking with glibc.

Add crt_static_respected to the linux_base target spec.

Update android_base and linux_musl_base accordingly. Avoid enabling
crt_static_respected on Android platforms, since that hasn't been
tested.

Closes #65447.

rust-highfive · 2020-10-01T04:29:39Z

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

joshtriplett · 2020-10-01T04:32:52Z

I've built and tested this, and confirmed that the resulting toolchain can compile statically linked executables on the x86_64-unknown-linux-gnu target.

Thanks to @petrochenkov for the original suggestion on how to accomplish this, and @JohnTitor for reviewing and merging my changes to the libc crate.

library/unwind/src/lib.rs

petrochenkov · 2020-10-01T17:33:59Z

LGTM, modulo the gcc_eh clarifications.

joshtriplett · 2020-10-01T18:13:44Z

@petrochenkov Done.

petrochenkov · 2020-10-01T22:08:09Z

r? @petrochenkov @bors r+

bors · 2020-10-01T22:08:11Z

📌 Commit 2e8f705 has been approved by petrochenkov

…henkov Support static linking with glibc and target-feature=+crt-static With this change, it's possible to build on a linux-gnu target and pass RUSTFLAGS='-C target-feature=+crt-static' or the equivalent via a `.cargo/config.toml` file, and get a statically linked executable. Update to libc 0.2.78, which adds support for static linking with glibc. Add `crt_static_respected` to the `linux_base` target spec. Update `android_base` and `linux_musl_base` accordingly. Avoid enabling crt_static_respected on Android platforms, since that hasn't been tested. Closes rust-lang#65447.

Dylan-DPC-zz · 2020-10-03T15:22:23Z

@bors r-

failed in rollup

joshtriplett · 2020-10-03T19:01:10Z

Fixing...

joshtriplett · 2020-10-03T23:06:09Z

Fixed. I separated the update to libc 0.2.78 into a separate commit, and fixed process_unix to work with it.

@bors r=petrochenkov

bors · 2020-10-03T23:06:10Z

📌 Commit d3b5dca2f922ff6743263d390c6aee1e2631664f has been approved by petrochenkov

joshtriplett · 2020-10-04T21:45:56Z

Fixing in rust-lang/libc#1911 .

This also fixes issues with inconsistent `unsafe` on functions.

This unifies it with the handling of `target-feature=+crt-static` on other platforms, and allows for supporting static glibc in the future.

With this change, it's possible to build on a linux-gnu target and pass RUSTFLAGS='-C target-feature=+crt-static' or the equivalent via a `.cargo/config.toml` file, and get a statically linked executable. This requires libc 0.2.79, which adds support for static linking with glibc. Add `crt_static_respected` to the `linux_base` target spec. Update `android_base` and `linux_musl_base` accordingly. Avoid enabling crt_static_respected on Android platforms, since that hasn't been tested.

joshtriplett · 2020-10-05T05:13:02Z

@bors r=petrochenkov

bors · 2020-10-05T05:13:04Z

📌 Commit d9f29fd has been approved by petrochenkov

bors · 2020-10-06T21:11:11Z

⌛ Testing commit d9f29fd with merge 98edd1f...

bors · 2020-10-06T23:07:10Z

☀️ Test successful - checks-actions, checks-azure
Approved by: petrochenkov
Pushing 98edd1f to master...

rust-log-analyzer · 2020-10-07T11:42:20Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

Clean up some of the pkgsrc Makefile, there's still lots in here that should just be deleted though. Switch SunOS to the illumos bootstrap by default. Version 1.48.0 (2020-11-19) ========================== Language -------- - [The `unsafe` keyword is now syntactically permitted on modules.][75857] This is still rejected *semantically*, but can now be parsed by procedural macros. Compiler -------- - [Stabilised the `-C link-self-contained=<yes|no>` compiler flag.][76158] This tells `rustc` whether to link its own C runtime and libraries or to rely on a external linker to find them. (Supported only on `windows-gnu`, `linux-musl`, and `wasi` platforms.) - [You can now use `-C target-feature=+crt-static` on `linux-gnu` targets.][77386] Note: If you're using cargo you must explicitly pass the `--target` flag. - [Added tier 2\* support for `aarch64-unknown-linux-musl`.][76420] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [`io::Write` is now implemented for `&ChildStdin` `&Sink`, `&Stdout`, and `&Stderr`.][76275] - [All arrays of any length now implement `TryFrom<Vec<T>>`.][76310] - [The `matches!` macro now supports having a trailing comma.][74880] - [`Vec<A>` now implements `PartialEq<[B]>` where `A: PartialEq<B>`.][74194] - [The `RefCell::{replace, replace_with, clone}` methods now all use `#[track_caller]`.][77055] Stabilized APIs --------------- - [`slice::as_ptr_range`] - [`slice::as_mut_ptr_range`] - [`VecDeque::make_contiguous`] - [`future::pending`] - [`future::ready`] The following previously stable methods are now `const fn`'s: - [`Option::is_some`] - [`Option::is_none`] - [`Option::as_ref`] - [`Result::is_ok`] - [`Result::is_err`] - [`Result::as_ref`] - [`Ordering::reverse`] - [`Ordering::then`] Cargo ----- Rustdoc ------- - [You can now link to items in `rustdoc` using the intra-doc link syntax.][74430] E.g. ``/// Uses [`std::future`]`` will automatically generate a link to `std::future`'s documentation. See ["Linking to items by name"][intradoc-links] for more information. - [You can now specify `#[doc(alias = "<alias>")]` on items to add search aliases when searching through `rustdoc`'s UI.][75740] Compatibility Notes ------------------- - [Promotion of references to `'static` lifetime inside `const fn` now follows the same rules as inside a `fn` body.][75502] In particular, `&foo()` will not be promoted to `'static` lifetime any more inside `const fn`s. - [Associated type bindings on trait objects are now verified to meet the bounds declared on the trait when checking that they implement the trait.][27675] - [When trait bounds on associated types or opaque types are ambiguous, the compiler no longer makes an arbitrary choice on which bound to use.][54121] - [Fixed recursive nonterminals not being expanded in macros during pretty-print/reparse check.][77153] This may cause errors if your macro wasn't correctly handling recursive nonterminal tokens. - [`&mut` references to non zero-sized types are no longer promoted.][75585] - [`rustc` will now warn if you use attributes like `#[link_name]` or `#[cold]` in places where they have no effect.][73461] - [Updated `_mm256_extract_epi8` and `_mm256_extract_epi16` signatures in `arch::{x86, x86_64}` to return `i32` to match the vendor signatures.][73166] - [`mem::uninitialized` will now panic if any inner types inside a struct or enum disallow zero-initialization.][71274] - [`#[target_feature]` will now error if used in a place where it has no effect.][78143] - [Foreign exceptions are now caught by `catch_unwind` and will cause an abort.][70212] Note: This behaviour is not guaranteed and is still considered undefined behaviour, see the [`catch_unwind`] documentation for further information. Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Building `rustc` from source now uses `ninja` by default over `make`.][74922] You can continue building with `make` by setting `ninja=false` in your `config.toml`. - [cg_llvm: `fewer_names` in `uncached_llvm_type`][76030] - [Made `ensure_sufficient_stack()` non-generic][76680] [78143]: rust-lang/rust#78143 [76680]: rust-lang/rust#76680 [76030]: rust-lang/rust#76030 [70212]: rust-lang/rust#70212 [27675]: rust-lang/rust#27675 [54121]: rust-lang/rust#54121 [71274]: rust-lang/rust#71274 [77386]: rust-lang/rust#77386 [77153]: rust-lang/rust#77153 [77055]: rust-lang/rust#77055 [76275]: rust-lang/rust#76275 [76310]: rust-lang/rust#76310 [76420]: rust-lang/rust#76420 [76158]: rust-lang/rust#76158 [75857]: rust-lang/rust#75857 [75585]: rust-lang/rust#75585 [75740]: rust-lang/rust#75740 [75502]: rust-lang/rust#75502 [74880]: rust-lang/rust#74880 [74922]: rust-lang/rust#74922 [74430]: rust-lang/rust#74430 [74194]: rust-lang/rust#74194 [73461]: rust-lang/rust#73461 [73166]: rust-lang/rust#73166 [intradoc-links]: https://doc.rust-lang.org/rustdoc/linking-to-items-by-name.html [`catch_unwind`]: https://doc.rust-lang.org/std/panic/fn.catch_unwind.html [`Option::is_some`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some [`Option::is_none`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_none [`Option::as_ref`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.as_ref [`Result::is_ok`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_ok [`Result::is_err`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_err [`Result::as_ref`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.as_ref [`Ordering::reverse`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.reverse [`Ordering::then`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.then [`slice::as_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_ptr_range [`slice::as_mut_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_mut_ptr_range [`VecDeque::make_contiguous`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.make_contiguous [`future::pending`]: https://doc.rust-lang.org/std/future/fn.pending.html [`future::ready`]: https://doc.rust-lang.org/std/future/fn.ready.html

Boscop · 2020-12-29T01:08:46Z

It doesn't work for me, I get this error:

RUSTFLAGS="-C target-feature=+crt-static" cargo build --release
error: cannot produce proc-macro for argh_derive v0.1.4 as the target x86_64-unknown-linux-gnu does not support these crate types

Any idea how to make it work? :)

rustc 1.50.0-nightly (1c389ffef 2020-11-24)

mati865 · 2020-12-29T01:27:28Z

@Boscop it's the issue reported in #78210

Pkgsrc changes: * Compensate for files being moved around upstream. * Introduce optional, on-by-default semi-static building of cargo, using the internal curl and openssl sources. This reduces the dynamic dependencies of cargo and therefore the rust package itself. Ref. options.mk. * The 1.47.0 bootstrap kits have been re-built with the above option turned on, so no longer depends on curl or openssl from pkgsrc and/or from earlier OS or pkgsrc versions. This should hopefully fix installation of rust with non-default PREFIX, ref. PR#54453. Upstream changes: Version 1.48.0 (2020-11-19) ========================== Language -------- - [The `unsafe` keyword is now syntactically permitted on modules.][75857] This is still rejected *semantically*, but can now be parsed by procedural macros. Compiler -------- - [Stabilised the `-C link-self-contained=<yes|no>` compiler flag.][76158] This tells `rustc` whether to link its own C runtime and libraries or to rely on a external linker to find them. (Supported only on `windows-gnu`, `linux-musl`, and `wasi` platforms.) - [You can now use `-C target-feature=+crt-static` on `linux-gnu` targets.] [77386] Note: If you're using cargo you must explicitly pass the `--target` flag. - [Added tier 2\* support for `aarch64-unknown-linux-musl`.][76420] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [`io::Write` is now implemented for `&ChildStdin` `&Sink`, `&Stdout`, and `&Stderr`.][76275] - [All arrays of any length now implement `TryFrom<Vec<T>>`.][76310] - [The `matches!` macro now supports having a trailing comma.][74880] - [`Vec<A>` now implements `PartialEq<[B]>` where `A: PartialEq<B>`.][74194] - [The `RefCell::{replace, replace_with, clone}` methods now all use `#[track_caller]`.][77055] Stabilized APIs --------------- - [`slice::as_ptr_range`] - [`slice::as_mut_ptr_range`] - [`VecDeque::make_contiguous`] - [`future::pending`] - [`future::ready`] The following previously stable methods are now `const fn`'s: - [`Option::is_some`] - [`Option::is_none`] - [`Option::as_ref`] - [`Result::is_ok`] - [`Result::is_err`] - [`Result::as_ref`] - [`Ordering::reverse`] - [`Ordering::then`] Cargo ----- Rustdoc ------- - [You can now link to items in `rustdoc` using the intra-doc link syntax.][74430] E.g. ``/// Uses [`std::future`]`` will automatically generate a link to `std::future`'s documentation. See ["Linking to items by name"][intradoc-links] for more information. - [You can now specify `#[doc(alias = "<alias>")]` on items to add search aliases when searching through `rustdoc`'s UI.][75740] Compatibility Notes ------------------- - [Promotion of references to `'static` lifetime inside `const fn` now follows the same rules as inside a `fn` body.][75502] In particular, `&foo()` will not be promoted to `'static` lifetime any more inside `const fn`s. - [Associated type bindings on trait objects are now verified to meet the bounds declared on the trait when checking that they implement the trait.][27675] - [When trait bounds on associated types or opaque types are ambiguous, the compiler no longer makes an arbitrary choice on which bound to use.][54121] - [Fixed recursive nonterminals not being expanded in macros during pretty-print/reparse check.][77153] This may cause errors if your macro wasn't correctly handling recursive nonterminal tokens. - [`&mut` references to non zero-sized types are no longer promoted.][75585] - [`rustc` will now warn if you use attributes like `#[link_name]` or `#[cold]` in places where they have no effect.][73461] - [Updated `_mm256_extract_epi8` and `_mm256_extract_epi16` signatures in `arch::{x86, x86_64}` to return `i32` to match the vendor signatures.][73166] - [`mem::uninitialized` will now panic if any inner types inside a struct or enum disallow zero-initialization.][71274] - [`#[target_feature]` will now error if used in a place where it has no effect.][78143] - [Foreign exceptions are now caught by `catch_unwind` and will cause an abort.][70212] Note: This behaviour is not guaranteed and is still considered undefined behaviour, see the [`catch_unwind`] documentation for further information. Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Building `rustc` from source now uses `ninja` by default over `make`.][74922] You can continue building with `make` by setting `ninja=false` in your `config.toml`. - [cg_llvm: `fewer_names` in `uncached_llvm_type`][76030] - [Made `ensure_sufficient_stack()` non-generic][76680] [78143]: rust-lang/rust#78143 [76680]: rust-lang/rust#76680 [76030]: rust-lang/rust#76030 [70212]: rust-lang/rust#70212 [27675]: rust-lang/rust#27675 [54121]: rust-lang/rust#54121 [71274]: rust-lang/rust#71274 [77386]: rust-lang/rust#77386 [77153]: rust-lang/rust#77153 [77055]: rust-lang/rust#77055 [76275]: rust-lang/rust#76275 [76310]: rust-lang/rust#76310 [76420]: rust-lang/rust#76420 [76158]: rust-lang/rust#76158 [75857]: rust-lang/rust#75857 [75585]: rust-lang/rust#75585 [75740]: rust-lang/rust#75740 [75502]: rust-lang/rust#75502 [74880]: rust-lang/rust#74880 [74922]: rust-lang/rust#74922 [74430]: rust-lang/rust#74430 [74194]: rust-lang/rust#74194 [73461]: rust-lang/rust#73461 [73166]: rust-lang/rust#73166 [intradoc-links]: https://doc.rust-lang.org/rustdoc/linking-to-items-by-name.html [`catch_unwind`]: https://doc.rust-lang.org/std/panic/fn.catch_unwind.html [`Option::is_some`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some [`Option::is_none`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_none [`Option::as_ref`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.as_ref [`Result::is_ok`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_ok [`Result::is_err`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_err [`Result::as_ref`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.as_ref [`Ordering::reverse`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.reverse [`Ordering::then`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.then [`slice::as_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_ptr_range [`slice::as_mut_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_mut_ptr_range [`VecDeque::make_contiguous`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.make_contiguous [`future::pending`]: https://doc.rust-lang.org/std/future/fn.pending.html [`future::ready`]: https://doc.rust-lang.org/std/future/fn.ready.html

rust-highfive assigned Mark-Simulacrum Oct 1, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2020

joshtriplett added relnotes Marks issues that should be documented in the release notes of the next release. O-linux Operating system: Linux labels Oct 1, 2020

jyn514 added the A-linkage Area: linking into static, shared libraries and binaries label Oct 1, 2020

petrochenkov self-assigned this Oct 1, 2020

mati865 reviewed Oct 1, 2020

View reviewed changes

library/unwind/src/lib.rs Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2020

joshtriplett added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 1, 2020

rust-highfive unassigned Mark-Simulacrum Oct 1, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2020

Dylan-DPC-zz mentioned this pull request Oct 3, 2020

Rollup of 9 pull requests #77483

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 3, 2020

joshtriplett force-pushed the static-glibc branch from 2e8f705 to d3b5dca Compare October 3, 2020 23:05

petrochenkov added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 4, 2020

joshtriplett added 4 commits October 4, 2020 22:12

Update libc to 0.2.79

16ebf75

This also fixes issues with inconsistent `unsafe` on functions.

unwind: Move linux-gnu library linking to lib.rs and libc

9d952cb

This unifies it with the handling of `target-feature=+crt-static` on other platforms, and allows for supporting static glibc in the future.

Add comment explaining why libunwind doesn't need to link libgcc_eh

d9f29fd

joshtriplett force-pushed the static-glibc branch from d3b5dca to d9f29fd Compare October 5, 2020 05:12

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 5, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 6, 2020

bors merged commit 98edd1f into rust-lang:master Oct 6, 2020

rustbot added this to the 1.49.0 milestone Oct 6, 2020

joshtriplett deleted the static-glibc branch October 6, 2020 23:17

mati865 mentioned this pull request Oct 22, 2020

"cannot produce proc-macro for crate as the target x86_64-unknown-linux-gnu does not support these crate types" with +crt-static #78210

Closed

fidencio mentioned this pull request Oct 29, 2020

agent: Experiment with the possibility to have the agent being statically linked to glibc kata-containers/kata-containers#1055

Closed

ehuss mentioned this pull request Nov 23, 2020

Update notes about static linking and MUSL rust-lang/edition-guide#224

Closed

Jakob-Naucke mentioned this pull request Jan 13, 2021

Some functions result in dynamically linked binaries with +crt-static on non-x86 linux gnu rust-lang/libc#2033

Closed

12101111 mentioned this pull request Apr 9, 2021

Refactor the linkage handling of libunwind #84040

Open

Skepfyr mentioned this pull request Jun 14, 2021

Compile error: static lifetime not satisfied but it is #86172

Open

rrbutani mentioned this pull request Sep 16, 2021

Adding support for cross compilation, CUDA, and sanitizers bazel-contrib/toolchains_llvm#90

Closed

petrochenkov mentioned this pull request Jun 18, 2022

build fully statically linked executable for Android not supported rust-lang/cargo#10765

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support static linking with glibc and target-feature=+crt-static #77386

Support static linking with glibc and target-feature=+crt-static #77386

joshtriplett commented Oct 1, 2020 •

edited by petrochenkov

Loading

rust-highfive commented Oct 1, 2020

joshtriplett commented Oct 1, 2020

petrochenkov commented Oct 1, 2020

joshtriplett commented Oct 1, 2020

petrochenkov commented Oct 1, 2020

bors commented Oct 1, 2020

Dylan-DPC-zz commented Oct 3, 2020

joshtriplett commented Oct 3, 2020

joshtriplett commented Oct 3, 2020

bors commented Oct 3, 2020

joshtriplett commented Oct 4, 2020

joshtriplett commented Oct 5, 2020

bors commented Oct 5, 2020

bors commented Oct 6, 2020

bors commented Oct 6, 2020

rust-log-analyzer commented Oct 7, 2020

Boscop commented Dec 29, 2020

mati865 commented Dec 29, 2020

Support static linking with glibc and target-feature=+crt-static #77386

Support static linking with glibc and target-feature=+crt-static #77386

Conversation

joshtriplett commented Oct 1, 2020 • edited by petrochenkov Loading

rust-highfive commented Oct 1, 2020

joshtriplett commented Oct 1, 2020

petrochenkov commented Oct 1, 2020

joshtriplett commented Oct 1, 2020

petrochenkov commented Oct 1, 2020

bors commented Oct 1, 2020

Dylan-DPC-zz commented Oct 3, 2020

joshtriplett commented Oct 3, 2020

joshtriplett commented Oct 3, 2020

bors commented Oct 3, 2020

joshtriplett commented Oct 4, 2020

joshtriplett commented Oct 5, 2020

bors commented Oct 5, 2020

bors commented Oct 6, 2020

bors commented Oct 6, 2020

rust-log-analyzer commented Oct 7, 2020

Boscop commented Dec 29, 2020

mati865 commented Dec 29, 2020

joshtriplett commented Oct 1, 2020 •

edited by petrochenkov

Loading