Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add revisions to const generic issue UI tests. #76514

Merged
merged 4 commits into from
Sep 10, 2020
Merged

Add revisions to const generic issue UI tests. #76514

merged 4 commits into from
Sep 10, 2020

Conversation

hameerabbasi
Copy link
Contributor

@hameerabbasi hameerabbasi commented Sep 9, 2020 •
edited
Loading

Fixes #75279.

I have gotten into the flow, so I can do more of these if requested. I'm looking for feedback as to whether my work is on the right track so far.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 9, 2020
@hameerabbasi hameerabbasi marked this pull request as draft September 9, 2020 11:29
@hameerabbasi
Copy link
Contributor Author

r? @lcnr

@rust-highfive rust-highfive assigned lcnr and unassigned nikomatsakis Sep 9, 2020
@jyn514 jyn514 added A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-const-generics Area: const generics (parameters and arguments) F-const_generics `#![feature(const_generics)]` F-min_const_generics labels Sep 9, 2020
lcnr
lcnr approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have gotten into the flow, so I can do more of these if requested. I'm looking for feedback as to whether my work is on the right track so far.

👍 this already looks good and is how I expected. I have a few nits, but I guess that's unavoidable with changes like this.

src/test/ui/const-generics/issues/issue-62187-encountered-polymorphic-const.min.stderr Outdated Show resolved Hide resolved
src/test/ui/const-generics/issues/issue-62878.stderr Show resolved Hide resolved
src/test/ui/const-generics/issues/issue-72787.rs Outdated Show resolved Hide resolved
src/test/ui/const-generics/issues/auxiliary/const_generic_issues_lib.rs Show resolved Hide resolved
@hameerabbasi hameerabbasi marked this pull request as ready for review September 10, 2020 07:32
@hameerabbasi hameerabbasi requested a review from lcnr September 10, 2020 07:34
@lcnr
Copy link
Contributor

lcnr commented Sep 10, 2020

@bors r+ rollup

thanks ❤️

@bors
Copy link
Contributor

bors commented Sep 10, 2020

📌 Commit bec8e5f has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2020
@tmandry tmandry mentioned this pull request Sep 10, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 10, 2020
@bors
Auto merge of rust-lang#76582 - tmandry:rollup-lwwc93b, r=tmandry
ad3a6f7 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#75857 (Syntactically permit unsafety on mods)
 - rust-lang#76289 (Add docs about crate level documentation support)
 - rust-lang#76514 (Add revisions to const generic issue UI tests.)
 - rust-lang#76524 (typeck: don't suggest inaccessible private fields)
 - rust-lang#76548 (Validate removal of AscribeUserType, FakeRead, and Shallow borrow)
 - rust-lang#76555 (Reword `trivial_casts` lint in rustc book to better explain what it does.)
 - rust-lang#76559 (add the `const_evaluatable_checked` feature)
 - rust-lang#76563 (small typo fix in rustc_parse docs)
 - rust-lang#76565 (take reference to Place directly instead of taking reference to Box<Place>)
 - rust-lang#76567 (use push(char) to add chars (single-char &strs) to strings instead of push_str(&str))
 - rust-lang#76568 (Add missing examples on core traits' method)

Failed merges:

r? `@ghost`
@bors bors merged commit 7565ccc into rust-lang:master Sep 10, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 10, 2020
@Amjad50 Amjad50 mentioned this pull request Sep 10, 2020
Closed
@lcnr lcnr mentioned this pull request Nov 17, 2020
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr Awaiting requested review from lcnr

Assignees

@lcnr lcnr

Labels
A-const-generics Area: const generics (parameters and arguments) A-testsuite Area: The testsuite used to check the correctness of rustc F-const_generics `#![feature(const_generics)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.

Use revisions to test min_const_generics
7 participants
@hameerabbasi @rust-highfive @lcnr @bors @nikomatsakis @jyn514 @rustbot