-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Free default()
forwarding to Default::default()
#73001
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
45 changes: 45 additions & 0 deletions
45
src/doc/unstable-book/src/library-features/default-free-fn.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
# `default_free_fn` | ||
|
||
The tracking issue for this feature is: [#73014] | ||
|
||
[#73014]: https://github.com/rust-lang/rust/issues/73014 | ||
|
||
------------------------ | ||
|
||
Adds a free `default()` function to the `std::default` module. This function | ||
just forwards to [`Default::default()`], but may remove repetition of the word | ||
"default" from the call site. | ||
|
||
Here is an example: | ||
|
||
```rust | ||
#![feature(default_free_fn)] | ||
use std::default::default; | ||
|
||
#[derive(Default)] | ||
struct AppConfig { | ||
foo: FooConfig, | ||
bar: BarConfig, | ||
} | ||
|
||
#[derive(Default)] | ||
struct FooConfig { | ||
foo: i32, | ||
} | ||
|
||
#[derive(Default)] | ||
struct BarConfig { | ||
bar: f32, | ||
baz: u8, | ||
} | ||
|
||
fn main() { | ||
let options = AppConfig { | ||
foo: default(), | ||
bar: BarConfig { | ||
bar: 10.1, | ||
..default() | ||
}, | ||
}; | ||
} | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nitpick I'd mention in any PR, but I guess it's extra strange now - here, why don't we prefer using the style
T::default()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to stick with
Default::default()
. The documentation of the function describes it as being equivalent toDefault::default()
and this reinforces that, even ifT::default()
would also be equivalent. It would be less clear for the documentation to describe the function as being equivalent toT::default()
becauseT::default()
has typeT
whileDefault::default()
has a type that is filled in by inference.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I'm here because avoiding
Default::default
is a pet peeve of mine, which in some way I must partly share with ilya-bobyr then. Since we say equivalent, any equivalent code would be fine, and I think we should prefer the style that we would like to see in Rust codebases around the ecosystem, henceT::default()
.If the docs say
Default::default
, maybe that could change now or in the future.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default::default()
was the first thing I thought about, as this is what I was trying to replace. If @dtolnay likesDefault::default()
more here, I would just leave it.