Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for bounds and asociated items when denying _ #69148

Merged
merged 3 commits into from
Feb 28, 2020
Merged

Account for bounds and asociated items when denying _ #69148

merged 3 commits into from
Feb 28, 2020

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Feb 13, 2020 •
edited
Loading

Fix #68801, #69204. Follow up to #67597 and #68071.

Output for the original ICE report:

    Checking vinoteca v5.0.0 (/Users/ekuber/workspace/vinoteca)
error[E0121]: the type placeholder `_` is not allowed within types on item signatures
  --> src/producers.rs:43:70
   |
43 | pub fn top<Table: diesel::Table + diesel::query_dsl::InternalJoinDsl<_, diesel::query_source::joins::Inner, _>>(table: Table, limit: usize, connection: DbConn) -> RestResult<Vec<TopWineType>> {
   |                                                                      ^ not allowed in type signatures       ^ not allowed in type signatures

error: aborting due to previous error

@estebank estebank added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 13, 2020
@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 13, 2020
@Centril
Copy link
Contributor

Centril commented Feb 13, 2020

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned cramertj Feb 13, 2020
@estebank estebank changed the title Account for bounds when denying _ in type parameters Account for bounds and asociated items when denying _ in type parameters Feb 17, 2020
@estebank estebank changed the title Account for bounds and asociated items when denying _ in type parameters Account for bounds and asociated items when denying _ Feb 17, 2020
@estebank estebank mentioned this pull request Feb 17, 2020
Closed
@hellow554 hellow554 mentioned this pull request Feb 18, 2020
Closed
@estebank
Copy link
Contributor Author

ping

@pnkfelix
Copy link
Member

discussed at T-compiler meeting. declined for beta backport.

"current decision: no backport because too big, but let us know if you want us to revisit the question"

@pnkfelix pnkfelix removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 20, 2020
@estebank
Copy link
Contributor Author

@pnkfelix saw the discussion, sounds fair. There's a very small fix that would cause duplicated output but would never ICE at the cost of the extra verbosity. Should I go ahead and do that?

@estebank
Copy link
Contributor Author

@Centril @oli-obk is on vacation, could you take a look at this?

estebank added a commit to estebank/rust that referenced this pull request Feb 20, 2020
@estebank
Backport only: avoid ICE on bad placeholder type
1cb555a 
 rust-lang#69148 has a proper fix, but it is too big to backport.
This change avoids the ICE by actually emitting an appropriate error. The
output will be duplicated in some cases, but that's better than the
avoidable ICE.
@estebank estebank mentioned this pull request Feb 20, 2020
Merged
@estebank estebank removed the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 20, 2020
@Centril
Copy link
Contributor

Centril commented Feb 24, 2020

@estebank Sorry, I don't think I have the time to invest into understanding this as well as I would want to to get to r+. :(

@oli-obk
Copy link
Contributor

oli-obk commented Feb 26, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Feb 26, 2020

📌 Commit d3ad814a276964dfcf293904f76f16494e54d4eb has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2020
@estebank
Copy link
Contributor Author

@bors r-

@oli-obk I'll rebase and r+ this after the backportable PR #69324 lands.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 26, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 27, 2020
@JohnTitor
Rollup merge of rust-lang#69324 - estebank:ice-break-backport-bad-pla…
add9338 
…ceholder-type, r=Centril

Backport only: avoid ICE on bad placeholder type

 rust-lang#69148 has a proper fix, but it is too big to backport.
This change avoids the ICE by actually emitting an appropriate error. The
output will be duplicated in some cases, but that's better than the
avoidable ICE.

r? @Centril
@bors
Copy link
Contributor

bors commented Feb 27, 2020

☔ The latest upstream changes (presumably #69507) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank
Copy link
Contributor Author

@bors r=oli-obk rebased on top of master with the other PR reverted

@bors
Copy link
Contributor

bors commented Feb 28, 2020

📌 Commit c6cfcf9 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 28, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 28, 2020
@Dylan-DPC
Rollup merge of rust-lang#69148 - estebank:cold-as-ice, r=oli-obk
0c3a8cd 
Account for bounds and asociated items when denying `_`

Fix rust-lang#68801, rust-lang#69204. Follow up to rust-lang#67597 and rust-lang#68071.

Output for the original ICE report:

```
    Checking vinoteca v5.0.0 (/Users/ekuber/workspace/vinoteca)
error[E0121]: the type placeholder `_` is not allowed within types on item signatures
  --> src/producers.rs:43:70
   |
43 | pub fn top<Table: diesel::Table + diesel::query_dsl::InternalJoinDsl<_, diesel::query_source::joins::Inner, _>>(table: Table, limit: usize, connection: DbConn) -> RestResult<Vec<TopWineType>> {
   |                                                                      ^ not allowed in type signatures       ^ not allowed in type signatures

error: aborting due to previous error
```
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Feb 28, 2020
Closed
@bors
Copy link
Contributor

bors commented Feb 28, 2020

⌛ Testing commit c6cfcf9 with merge eaa02f5...

@bors
Copy link
Contributor

bors commented Feb 28, 2020

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing eaa02f5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 28, 2020
@bors bors merged commit eaa02f5 into rust-lang:master Feb 28, 2020
@estebank estebank mentioned this pull request Mar 23, 2020
Merged
Centril added a commit to Centril/rust that referenced this pull request Mar 23, 2020
@Centril
Rollup merge of rust-lang#70294 - estebank:bad-placeholder-in-where, …
de1b094 
…r=Centril

Account for bad placeholder types in where clauses

Fix rust-lang#70291. Follow up to rust-lang#69148.
Centril added a commit to Centril/rust that referenced this pull request Mar 23, 2020
@Centril
Rollup merge of rust-lang#70294 - estebank:bad-placeholder-in-where, …
b07333c 
…r=Centril

Account for bad placeholder types in where clauses

Fix rust-lang#70291. Follow up to rust-lang#69148.
Centril added a commit to Centril/rust that referenced this pull request Mar 23, 2020
@Centril
Rollup merge of rust-lang#70294 - estebank:bad-placeholder-in-where, …
54db0cf 
…r=Centril

Account for bad placeholder types in where clauses

Fix rust-lang#70291. Follow up to rust-lang#69148.
@estebank estebank mentioned this pull request Oct 3, 2020
Closed
@dwrensha dwrensha mentioned this pull request Oct 14, 2021
Closed
@estebank estebank deleted the cold-as-ice branch November 9, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'index out of bounds: the len is 1 but the index is 1': libcore/slice/mod.rs
7 participants
@estebank @rust-highfive @Centril @pnkfelix @oli-obk @bors @cramertj