Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add long error explanation for E0588 #65591

Merged
merged 3 commits into from
Oct 23, 2019
Merged

Add long error explanation for E0588 #65591

merged 3 commits into from
Oct 23, 2019

Conversation

GuillaumeGomez
Copy link
Member

Part of #61137.

r? @kinnison

@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 19, 2019
Closed
100 tasks
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-10-19T09:33:50.4941509Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-19T09:33:50.5136849Z ##[command]git config gc.auto 0
2019-10-19T09:33:50.5222637Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-19T09:33:50.5277430Z ##[command]git config --get-all http.proxy
2019-10-19T09:33:50.5440095Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65591/merge:refs/remotes/pull/65591/merge
---
2019-10-19T10:39:12.8902307Z .................................................................................................... 1600/9199
2019-10-19T10:39:18.3949005Z .................................................................................................... 1700/9199
2019-10-19T10:39:32.0026971Z ..............................i...............i..................................................... 1800/9199
2019-10-19T10:39:39.9942772Z .................................................................................................... 1900/9199
2019-10-19T10:39:55.3173934Z ....................iiiii........................................................................... 2000/9199
2019-10-19T10:40:06.3231509Z .................................................................................................... 2200/9199
2019-10-19T10:40:08.9266337Z .................................................................................................... 2300/9199
2019-10-19T10:40:14.4643119Z .................................................................................................... 2400/9199
2019-10-19T10:40:37.7946697Z .................................................................................................... 2500/9199
---
2019-10-19T10:43:42.1589869Z .......................i...............i............................................................ 4800/9199
2019-10-19T10:43:54.5832906Z .................................................................................................... 4900/9199
2019-10-19T10:44:01.0841922Z .................................................................................................... 5000/9199
2019-10-19T10:44:11.3902291Z .................................................................................................... 5100/9199
2019-10-19T10:44:18.7808510Z .......................ii.ii........................................................................ 5200/9199
2019-10-19T10:44:29.6094375Z .................................................................................................... 5400/9199
2019-10-19T10:44:39.9996200Z .........................................................................................i.......... 5500/9199
2019-10-19T10:44:48.5586413Z .................................................................................................... 5600/9199
2019-10-19T10:44:53.6784108Z .................................................................................................... 5700/9199
2019-10-19T10:44:53.6784108Z .................................................................................................... 5700/9199
2019-10-19T10:45:05.0127211Z ......................................................................................ii...i..ii.... 5800/9199
2019-10-19T10:45:32.5070032Z .................................................................................................... 6000/9199
2019-10-19T10:45:42.4634079Z .................................................................................................... 6100/9199
2019-10-19T10:45:51.6710915Z .................................................................................................... 6200/9199
2019-10-19T10:45:51.6710915Z .................................................................................................... 6200/9199
2019-10-19T10:46:06.1836325Z ........i..ii....................................................................................... 6300/9199
2019-10-19T10:46:26.9344330Z ....................................................................i............................... 6500/9199
2019-10-19T10:46:29.2314335Z .................................................................................................... 6600/9199
2019-10-19T10:46:31.8172626Z ...........................................i........................................................ 6700/9199
2019-10-19T10:46:35.8074437Z .................................................................................................... 6800/9199
---
2019-10-19T10:51:18.3025785Z  finished in 5.558
2019-10-19T10:51:18.3215527Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-19T10:51:18.4924910Z 
2019-10-19T10:51:18.4925924Z running 153 tests
2019-10-19T10:51:21.8412959Z i....iii......iii..iiii...i.............................i..i..................i....i...........ii.i. 100/153
2019-10-19T10:51:23.9189800Z i..iiii..............i.........iii.i.........ii......
2019-10-19T10:51:23.9193888Z 
2019-10-19T10:51:23.9195499Z  finished in 5.597
2019-10-19T10:51:23.9388584Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-19T10:51:24.1097428Z 
---
2019-10-19T10:51:26.2539590Z  finished in 2.315
2019-10-19T10:51:26.2753884Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-19T10:51:26.4436369Z 
2019-10-19T10:51:26.4437301Z running 9 tests
2019-10-19T10:51:26.4438787Z iiiiiiiii
2019-10-19T10:51:26.4439211Z 
2019-10-19T10:51:26.4439302Z  finished in 0.168
2019-10-19T10:51:26.4638766Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-19T10:51:26.6329854Z 
---
2019-10-19T10:51:45.5474537Z  finished in 19.083
2019-10-19T10:51:45.5684101Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-19T10:51:45.7484209Z 
2019-10-19T10:51:45.7484560Z running 123 tests
2019-10-19T10:52:11.0502745Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-10-19T10:52:15.9376380Z i.i.i......iii.i.....ii
2019-10-19T10:52:15.9376866Z 
2019-10-19T10:52:15.9379164Z  finished in 30.370
2019-10-19T10:52:15.9389774Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-19T10:52:15.9390105Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-10-19T11:05:32.6008044Z 
2019-10-19T11:05:32.6012591Z    Doc-tests core
2019-10-19T11:05:37.9177403Z 
2019-10-19T11:05:37.9178498Z running 2406 tests
2019-10-19T11:05:49.1320038Z ......iiiii......................................................................................... 100/2406
2019-10-19T11:06:00.2702771Z ................................................................................ii.................. 200/2406
2019-10-19T11:06:26.5208476Z ..i................................................................................................. 400/2406
2019-10-19T11:06:26.5208476Z ..i................................................................................................. 400/2406
2019-10-19T11:06:37.2539993Z .................................................i..i.................iiii.......................... 500/2406
2019-10-19T11:06:58.0790750Z .................................................................................................... 700/2406
2019-10-19T11:07:08.7724463Z .................................................................................................... 800/2406
2019-10-19T11:07:19.4112099Z .................................................................................................... 900/2406
2019-10-19T11:07:30.0946714Z .................................................................................................... 1000/2406
---
2019-10-19T11:11:51.4182343Z 
2019-10-19T11:11:51.4187369Z running 994 tests
2019-10-19T11:12:13.7263860Z i................................................................................................... 100/994
2019-10-19T11:12:25.7496419Z .................................................................................................... 200/994
2019-10-19T11:12:34.4068399Z ...................iii......i......i...i......i..................................................... 300/994
2019-10-19T11:12:40.4178411Z .................................................................................................... 400/994
2019-10-19T11:12:48.4319522Z .....................................i..i.................................ii........................ 500/994
2019-10-19T11:13:03.8331372Z .................................................................................................... 700/994
2019-10-19T11:13:03.8331372Z .................................................................................................... 700/994
2019-10-19T11:13:12.2882228Z ....................iiii............................................................................ 800/994
2019-10-19T11:13:27.9714924Z .................................................................................................... 900/994
2019-10-19T11:13:35.9359408Z ..........................................iiii................................................
2019-10-19T11:13:35.9360436Z 
2019-10-19T11:13:35.9463039Z  finished in 204.099
2019-10-19T11:13:35.9482162Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-19T11:13:36.1766604Z    Compiling term v0.0.0 (/checkout/src/libterm)
---
2019-10-19T11:30:36.6581008Z 
2019-10-19T11:30:36.6581054Z failures:
2019-10-19T11:30:36.6581082Z 
2019-10-19T11:30:36.6581593Z ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0588 (line 10743) stdout ----
2019-10-19T11:30:36.6581742Z error[E0588]: packed type cannot transitively contain a `[repr(align)]` type
2019-10-19T11:30:36.6582065Z  --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:10748:1
2019-10-19T11:30:36.6582131Z   |
2019-10-19T11:30:36.6582177Z 7 | struct Aligned(Packed);
2019-10-19T11:30:36.6582250Z 
2019-10-19T11:30:36.6582310Z error: aborting due to previous error
2019-10-19T11:30:36.6582339Z 
2019-10-19T11:30:36.6582604Z For more information about this error, try `rustc --explain E0588`.
---
2019-10-19T11:30:36.6591303Z   local time: Sat Oct 19 11:30:36 UTC 2019
2019-10-19T11:30:36.7642594Z   network time: Sat, 19 Oct 2019 11:30:36 GMT
2019-10-19T11:30:36.7647959Z == end clock drift check ==
2019-10-19T11:30:37.6376320Z 
2019-10-19T11:30:37.6494142Z ##[error]Bash exited with code '1'.
2019-10-19T11:30:37.6539586Z ##[section]Starting: Checkout
2019-10-19T11:30:37.6541511Z ==============================================================================
2019-10-19T11:30:37.6541576Z Task         : Get sources
2019-10-19T11:30:37.6541620Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@JohnTitor JohnTitor added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 19, 2019
@GuillaumeGomez GuillaumeGomez force-pushed the long-err-explanation-E0588 branch from acaca50 to 2541d49 Compare October 20, 2019 11:01
@GuillaumeGomez
Copy link
Member Author

Updated.

kinnison
kinnison approved these changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kinnison
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 20, 2019

@kinnison: 🔑 Insufficient privileges: Not in reviewers

Centril
Centril reviewed Oct 21, 2019
View reviewed changes
src/librustc_typeck/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_typeck/error_codes.rs Outdated Show resolved Hide resolved
@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

@kinnison
Copy link
Contributor

@Dylan-DPC 👍

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 22, 2019

📌 Commit 07f2f05 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 22, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 23, 2019
@JohnTitor
Rollup merge of rust-lang#65591 - GuillaumeGomez:long-err-explanation…
6f6f3e8 
…-E0588, r=Dylan-DPC

Add long error explanation for E0588

Part of rust-lang#61137.

r? @kinnison
@JohnTitor JohnTitor mentioned this pull request Oct 23, 2019
Merged
bors added a commit that referenced this pull request Oct 23, 2019
@bors
Auto merge of #65716 - JohnTitor:rollup-fkcr85k, r=JohnTitor
f466f52 
Rollup of 14 pull requests

Successful merges:

 - #64145 (Target-feature documented as unsafe)
 - #65007 (Mention keyword closing policy)
 - #65417 (Add more coherence tests)
 - #65507 (Fix test style in unused parentheses lint test)
 - #65591 (Add long error explanation for E0588)
 - #65617 (Fix WASI sleep impl)
 - #65656 (Add option to disable keyboard shortcuts in docs)
 - #65678 (Add long error explanation for E0728)
 - #65681 (Code cleanups following up on #65576.)
 - #65686 (refactor and move `maybe_append` )
 - #65688 (Add some tests for fixed ICEs)
 - #65689 (bring back some Debug instances for Miri)
 - #65695 (self-profiling: Remove module names from some event-ids in codegen backend.)
 - #65706 (Add missing space in librustdoc)

Failed merges:

r? @ghost
@bors bors merged commit 07f2f05 into rust-lang:master Oct 23, 2019
@GuillaumeGomez GuillaumeGomez deleted the long-err-explanation-E0588 branch October 23, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

@kinnison kinnison kinnison approved these changes

Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@GuillaumeGomez @rust-highfive @kinnison @bors @Dylan-DPC-zz @Centril @JohnTitor @Dylan-DPC