rustc_mir: fix miri substitution/"universe" discipline. #63497
Conversation
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
I can confirm that this fixes the test-case in rust-lang/miri#837 :) |
This comment has been minimized.
This comment has been minimized.
|
@eddyb the base PR landed, so after a rebase this should be ready for review. :) |
RalfJung
added
S-waiting-on-author
eddyb
added
S-waiting-on-review
|
Also fixes #61432, please add the test case from the issue. After my nit our PRs should be synchronized, I just stepped through their diffs and I'd rather merge this PR since it's diff is cleaner |
fix an ICE fix method name
|
@oli-obk Should be good to go now, thanks! |
|
@bors r+ |
|
📌 Commit 96fc989 has been approved by |
bors
added
S-waiting-on-bors
rustc_mir: fix miri substitution/"universe" discipline. Alternative to rust-lang#61041, based on @RalfJung's own attempt at it. I haven't done a full audit, but I believe everything is fixed now. Fixes rust-lang#61432. Closes rust-lang#61336, as a drive-by fix (for a subset of rust-lang#43408, that is already special-cased). r? @oli-obk / @RalfJung cc @varkor @yodaldevoid
rustc_mir: fix miri substitution/"universe" discipline. Alternative to #61041, based on @RalfJung's own attempt at it. I haven't done a full audit, but I believe everything is fixed now. Fixes #61432. Closes #61336, as a drive-by fix (for a subset of #43408, that is already special-cased). r? @oli-obk / @RalfJung cc @varkor @yodaldevoid
|
☀️ Test successful - checks-azure |
| | | ||
| = note: the method `HOST_SIZE` exists but the following trait bounds were not satisfied: | ||
| `A : std::marker::Sized` | ||
| `B : std::marker::Sized` |
There was a problem hiding this comment.
Those trait bounds are implicit when not using : ?Sized right?
There was a problem hiding this comment.
that's a different bug. This regression test is to prevent the ICE from recurring. The fact that what's done in the test is unsupported by rustc is likely lazy normalization (allowing array length constants to refer to generics of the surrounding scope)
There was a problem hiding this comment.
(And it should stay unsupported on stable without T-Lang approval.)
Alternative to #61041, based on @RalfJung's own attempt at it.
I haven't done a full audit, but I believe everything is fixed now.
Fixes #61432.
Closes #61336, as a drive-by fix (for a subset of #43408, that is already special-cased).
r? @oli-obk / @RalfJung cc @varkor @yodaldevoid